Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Firewall Rule button falsely returns success in UI #301

Open
bryonadams opened this issue Mar 25, 2023 · 0 comments
Open

Repair Firewall Rule button falsely returns success in UI #301

bryonadams opened this issue Mar 25, 2023 · 0 comments

Comments

@bryonadams
Copy link

bryonadams commented Mar 25, 2023

While not running ACT as an adminstrator, clicking the "Repair Firewall Rule" button under Plugins > FFXIV ACT Plugin, the UI pops up stating with a message that indicates a success; "Advanced Compat Tracker Firewall rule removed and re-added," but the log message with debugs enables indicates it failed.

[19:52:06.872] FFXIV_ACT_Plugin Version: 2.6.8.1 (50BCD605C50A749F)
... <snip>
[20:03:54.920] Error updating firewall.  System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))    at WindowsFirewallHelper.COMInterop.INetFwRules.Remove(String name)    at WindowsFirewallHelper.FirewallAPIv2.Firewall.RulesOnItemsModified(Object sender, ActiveCollectionChangedEventArgs`1 e)    at System.Collections.ObjectModel.Collection`1.Remove(T item)    at FFXIV_ACT_Plugin.Network.FirewallManager.FixFirewallRules()

Viewing the inbound firewall rules on Windows confirms that the rule is not added/fixed if the rule is removed before testing.

Interestingly, running ACT as admin causes no debug log to be printed but it does work.

Should the plugin respond indicating a success in the UI even though it detects it failed to edit the firewall rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant