-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual] Allow to change color/style mode #29
Comments
Do you think this would be best in the config file, or somewhere else in the webpage. I can probably fairly easily implement a "minimalist" white/black theme. |
A button e.g. at the top right of the dashboard would be awesome in my personal opinion, so it can be easily switched e.g. when you realise that the sun went down. But don't invest too much time when it's not very easy to implement, as long as you are not in mood to play with exactly this 🙂. |
Sorry, I meant for themes. A dark mode trigger is actually much easier than you think, Tailwind/WindiCSS has a built-in setting for that. |
Ah nice. For the color theme I see it similar: Nice to have a setting in the dashboard UI but a config file setting would do as well. |
Dark mode trigger added with 38bbd3a. |
Also, a different visual change, but instead of changing pages instantly and showing "Getting Data", the page will now blur until the websocket message is received, and then change. How do you think it looks? |
Legend 👍, works very well. The sidebar should probably have colors inverted as well? Also currently the selection isn't stored, hence reloading the site will always show in dark mode. I faced another issue now: When reloading or initially accessing a page that is not the entry/statistics page, like Just retested with current stable release, and there every page can be reloaded of opened initially, so this is probably related to the EDIT: dc01d90 EDIT2: Though, EDIT3: The browser console shows a related error:
Pointing to: function ls(s) {
let t, e, l, n, r, o = s[0].services, a = [];
for (let c = 0; c < o.length; c += 1)
a[c] = Bt(At(s, o, c)); And similar loops on each page (EDIT: with a table where data needs to be derived for). It seems to be the data is not read when reloading the page compared to navigating to it, and this may be the loop to create the table. Indeed it works well with the Management, File Browser and Terminal pages, where no (or different kind of) tables are shown. |
It's because the data doesn't come immediately. This works for most pages because it's not trying to iterate over EDIT: Done with 8c8b63c |
Alright, the library I was planning to use isn't going to work (see below). There's a request in windicss for multiple themes, but not much work has been done on it. |
Currently we have a pretty dark mode design, which is fine. Mid/Long term it would be great to have a toggle to enable a bright mode and/or even change the accent colour from green to something else. We just need to assure that the DietPi logo keeps looking good 😄.
Linking the original request by @GvY85: MichaIng/DietPi#448 (comment)
I personally would give this a low priority currently, and concentrate on stability first, but of course if someone is in mood to start with this, we are always open to pull requests.
The text was updated successfully, but these errors were encountered: