Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [improvement] Security Concern: Exposing Email Credentials #148

Open
Madhav-MKNC opened this issue Jun 19, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@Madhav-MKNC
Copy link

Describe the bug
I would like to bring attention to a significant security concern within the current implementation of this project. The issue revolves around the requirement of providing email credentials as a parameter during the login process.

Background:
The PyChatGPT project offers a convenient method for utilizing the ChatGPT model without relying on an API. However, the current approach introduces a severe security vulnerability by asking users to supply their email and password as input parameters for the login function. This practice is inherently unsafe and can potentially expose sensitive user data.

To Reproduce
I propose the following alternatives:

  1. OAuth Integration: Utilize established authentication mechanisms such as OAuth, which allows users to authenticate through trusted third-party providers (e.g., Google, Facebook, GitHub) without exposing their credentials directly.

  2. Token-based Authentication: Implement a token-based authentication system where users are issued a unique access token upon successful login. This token can then be used for subsequent API calls, reducing the risk of exposing sensitive information.

  3. API Key Approach: Consider employing an API key-based authentication method, wherein users are assigned a unique key that is securely stored and exchanged during the authentication process.

Conclusion
I urge the project maintainers to prioritize user security and promptly address this issue by implementing a more secure authentication method. Protecting user data is of paramount importance, and eliminating the requirement to expose email credentials will significantly reduce the risk of unauthorized access and potential privacy breaches.

@Madhav-MKNC Madhav-MKNC added the bug Something isn't working label Jun 19, 2023
@Madhav-MKNC Madhav-MKNC changed the title [BUG] Security Concern: Exposing Email Credentials [BUG] [enhancement] Security Concern: Exposing Email Credentials Jun 19, 2023
@Madhav-MKNC Madhav-MKNC changed the title [BUG] [enhancement] Security Concern: Exposing Email Credentials [BUG] [improvement] Security Concern: Exposing Email Credentials Jun 19, 2023
@BC79
Copy link

BC79 commented Jan 19, 2024

Is this using https for communications?
Also for extra safety running it in a iptables jail means these coms can't be leaked anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants