Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

@close does not fire when and item is selected #23

Closed
ChuckFields opened this issue May 30, 2019 · 3 comments
Closed

@close does not fire when and item is selected #23

ChuckFields opened this issue May 30, 2019 · 3 comments

Comments

@ChuckFields
Copy link

ChuckFields commented May 30, 2019

Description

@close does not fire when the context menu is closed via selecting an item with the mouse or with the keyboard.

Version

4.0.0

@rawilk
Copy link
Owner

rawilk commented May 31, 2019

I will look into this

@rawilk
Copy link
Owner

rawilk commented Jun 3, 2019

@ChuckFields

After looking at it, I forgot that I had a conditional in there when I first implemented this. Apparently it was emitting the close event twice for some reason when I first did that so I just elected to not emit it on click events.

After playing around with it, it seems that's not the case anymore and now I've dropped that conditional and updated the package. If you update to version 4.0.1 it should always emit the the close event now for you anytime the menu is closed.

@ChuckFields
Copy link
Author

@rawilk Works perfectly, thank you. I'll close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants