Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover from timeout #24

Open
abh opened this issue Mar 12, 2012 · 2 comments
Open

recover from timeout #24

abh opened this issue Mar 12, 2012 · 2 comments

Comments

@abh
Copy link

abh commented Mar 12, 2012

If a deployment job "hangs", there doesn't seem to be a way to recover other than restarting the process.

@russellhaering
Copy link
Contributor

Yeah, this is a problem we need to figure out how to deal with. Much of the difficulty stems from the fact that there is no convention in node for canceling/stopping a set of related ongoing operations.

One approach would be to develop our own convention and attach a reference to every ongoing operation to the baton so that if a deployment times out (or is canceled) they can all be canceled or killed if possible.

A second approach, which seems much safer to me, is to run deployments in a subprocess (or maybe use isolates?). There are a few other potential advantages to this as well (throwing an error in a deployment wouldn't crash Dreadnot), so pursuing it is definitely high on my list of priorities.

@abh
Copy link
Author

abh commented Mar 14, 2012

A subprocess would make sense to me. Isolates didn't make it far: http://groups.google.com/group/nodejs/msg/6b8b8a487d2ab817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants