Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-avy equivalent #16

Closed
noctuid opened this issue Feb 6, 2020 · 9 comments
Closed

ivy-avy equivalent #16

noctuid opened this issue Feb 6, 2020 · 9 comments

Comments

@noctuid
Copy link

noctuid commented Feb 6, 2020

It's nice to be able to quickly select an entry that is not at the top without further narrowing.

@raxod502
Copy link
Member

raxod502 commented Feb 9, 2020

I would prefer to have the option to display indices, and then allow keybindings to select a candidate by number (for example, using C-1 through C-9, like Company has). Does that sound like a reasonable alternative to the Avy interface to you?

@noctuid
Copy link
Author

noctuid commented Feb 13, 2020

The nice thing about ivy-avy is being able to use customizable home row keys (I don't use qwerty) to select a candidate. But it takes an extra key to start it, and I can use an extra modifier to put numbers on the home row. Avy is also hypothetically nice if there are a lot of candidates, but I don't think I've ever selected outside the first 9. I think numbered indices and commands for selecting a numbered candidate would be good enough. I'm guessing it would be possible to implement the equivalent of ivy-avy as a separate package if someone really wanted it.

@raxod502
Copy link
Member

Okay -- let's implement the numbered indices as an optional parameter in Selectrum proper, then, and then add some hooks that could be used to implement a more general scheme if somebody comes along who can make a good argument for something more being necessary.

@raxod502
Copy link
Member

Let me know how this feature works for you.

@raxod502 raxod502 added the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Apr 17, 2020
@noctuid
Copy link
Author

noctuid commented Apr 20, 2020

Thanks, it works as expected.

@noctuid noctuid closed this as completed Apr 20, 2020
@raxod502 raxod502 removed the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Apr 22, 2020
@noctuid
Copy link
Author

noctuid commented Apr 24, 2020

One thing I've noticed that could maybe be improved is that everything shifts left as you narrow the number of candidates. For example, if there are 1000 candicates, there will be two spaces of padding. Once there are 999, the visible candidates will shift one character left and so forth. It's not terrible, but it's a little jarring. If possible, it might be nice to just keep the initial padding characters in place for the session.

@noctuid noctuid reopened this Apr 24, 2020
@raxod502
Copy link
Member

Reasonable. Let me know what you think.

@raxod502 raxod502 added the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Apr 25, 2020
@noctuid
Copy link
Author

noctuid commented Apr 25, 2020

Thanks, it works well.

@noctuid noctuid closed this as completed Apr 25, 2020
@raxod502 raxod502 removed the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Apr 26, 2020
@clemera
Copy link
Collaborator

clemera commented Mar 9, 2021

#479 added functionality similar to ivy-avy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants