Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

straight-thaw-versions requires fetch #58

Closed
raxod502 opened this issue Jun 28, 2017 · 2 comments
Closed

straight-thaw-versions requires fetch #58

raxod502 opened this issue Jun 28, 2017 · 2 comments

Comments

@raxod502
Copy link
Member

You may need to update your repositories or remotes in order to check out the correct commit.

@raxod502 raxod502 added the bug label Jun 28, 2017
@raxod502 raxod502 mentioned this issue Jun 28, 2017
56 tasks
@raxod502 raxod502 added this to the 1.0 milestone Jun 28, 2017
@raxod502
Copy link
Member Author

raxod502 commented Jun 4, 2018

To clarify, I mean that fetching should be done automatically, since I think that would be an improvement in UX. See also #280.

@raxod502 raxod502 added the ux label Jun 4, 2018
antifuchs added a commit to antifuchs/straight.el that referenced this issue Apr 20, 2019
This should address radian-software#58: If we're unable to find the commit locally,
the easiest way to get it is probably to fetch it.
antifuchs added a commit to antifuchs/straight.el that referenced this issue May 1, 2019
This should address radian-software#58: If we're unable to find the commit locally,
the easiest way to get it is probably to fetch it.
raxod502 pushed a commit that referenced this issue May 4, 2019
* New function straight-vc-commit-present-p: check if a SHA is fetched

This function should allow us to detect if a "git fetch" is necessary
upon thawing the repo.

* Automatically fetch the repo when the thawed-to commit is missing

This should address #58: If we're unable to find the commit locally,
the easiest way to get it is probably to fetch it.

* Normalize repos when thawing

Since we're already going to munge the repo state, we might as well
return it to the master branch and thus get it to a place where the
fetch can do something reasonable.

* Instead of decapitating via checkout, reset the HEAD ref

This should address #294: When thawing, we no longer leave detached
heads lying around, so freezing the repo will be much more likely to
be a high-touch operation. Also, this should leave the repos that we
*do* have in a much nicer state for people to work on.

* Remove note about running fetch before thawing.

With the auto-fetching behavior, I believe this should be unnecessary
now.

* Adjust straight-vc-check-out-commit to normalize the repo

This requires the interface for the function to change: Previously it
took just the local-repo, now it takes the whole recipe (because
that's what normalization uses).
@raxod502
Copy link
Member Author

raxod502 commented May 4, 2019

Should be fixed by #375.

@raxod502 raxod502 closed this as completed May 4, 2019
hartzell pushed a commit to hartzell/straight.el that referenced this issue Jun 14, 2019
* New function straight-vc-commit-present-p: check if a SHA is fetched

This function should allow us to detect if a "git fetch" is necessary
upon thawing the repo.

* Automatically fetch the repo when the thawed-to commit is missing

This should address radian-software#58: If we're unable to find the commit locally,
the easiest way to get it is probably to fetch it.

* Normalize repos when thawing

Since we're already going to munge the repo state, we might as well
return it to the master branch and thus get it to a place where the
fetch can do something reasonable.

* Instead of decapitating via checkout, reset the HEAD ref

This should address radian-software#294: When thawing, we no longer leave detached
heads lying around, so freezing the repo will be much more likely to
be a high-touch operation. Also, this should leave the repos that we
*do* have in a much nicer state for people to work on.

* Remove note about running fetch before thawing.

With the auto-fetching behavior, I believe this should be unnecessary
now.

* Adjust straight-vc-check-out-commit to normalize the repo

This requires the interface for the function to change: Previously it
took just the local-repo, now it takes the whole recipe (because
that's what normalization uses).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant