You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. -->
1
+
<!-- Thank you for contributing to Ray! 🚀 -->
2
+
<!-- Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. -->
3
+
<!-- 💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete -->
2
4
3
-
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
5
+
## Description
4
6
5
-
## Why are these changes needed?
7
+
<!-- Briefly describe what this PR accomplishes and why it's needed-->
6
8
7
-
<!-- Please give a short summary of the change and the problem this solves. -->
9
+
## Related issues
8
10
9
-
## Related issue number
11
+
<!-- Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234" -->
10
12
11
-
<!-- For example: "Closes #1234" -->
13
+
## Types of change
12
14
13
-
## Checks
15
+
-[ ] Bug fix 🐛
16
+
-[ ] New feature ✨
17
+
-[ ] Enhancement 🚀
18
+
-[ ] Code refactoring 🔧
19
+
-[ ] Documentation update 📖
20
+
-[ ] Chore 🧹
21
+
-[ ] Style 🎨
14
22
15
-
-[ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR.
16
-
-[ ] I've run pre-commit jobs to lint the changes in this PR. ([pre-commit setup](https://docs.ray.io/en/latest/ray-contribute/getting-involved.html#lint-and-formatting))
17
-
-[ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
18
-
-[ ] I've added any new APIs to the API Reference. For example, if I added a
19
-
method in Tune, I've added it in `doc/source/tune/api/` under the
20
-
corresponding `.rst` file.
21
-
-[ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
22
-
- Testing Strategy
23
-
-[ ] Unit tests
24
-
-[ ] Release tests
25
-
-[ ] This PR is not tested :(
23
+
## Checklist
24
+
25
+
**Does this PR introduce breaking changes?**
26
+
-[ ] Yes ⚠️
27
+
-[ ] No
28
+
<!-- If yes, describe what breaks and how users should migrate -->
29
+
30
+
**Testing:**
31
+
-[ ] Added/updated tests for my changes
32
+
-[ ] Tested the changes manually
33
+
-[ ] This PR is not tested ❌ _(please explain why)_
34
+
35
+
**Code Quality:**
36
+
-[ ] Signed off every commit (`git commit -s`)
37
+
-[ ] Ran pre-commit hooks ([setup guide](https://docs.ray.io/en/latest/ray-contribute/getting-involved.html#lint-and-formatting))
DOC201: Function `serve_start` does not have a return section in docstring
1529
1529
--------------------
1530
1530
python/ray/serve/_private/application_state.py
1531
-
DOC001: Method `__init__` Potential formatting errors in docstring. Error message: No specification for "Args": ""
1532
-
DOC001: Function/method `__init__`: Potential formatting errors in docstring. Error message: No specification for "Args": "" (Note: DOC001 could trigger other unrelated violations under this function/method too. Please fix the docstring formatting first.)
1533
-
DOC101: Method `ApplicationState.__init__`: Docstring contains fewer arguments than in function signature.
1534
-
DOC103: Method `ApplicationState.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [deployment_state_manager: DeploymentStateManager, endpoint_state: EndpointState, logging_config: LoggingConfig, name: str].
1535
1531
DOC103: Method `ApplicationStateManager.deploy_app`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [deployment_args: List[Dict]]. Arguments in the docstring but not in the function signature: [deployment_args_list: ].
1536
1532
DOC102: Function `override_deployment_info`: Docstring contains more arguments than in function signature.
1537
1533
DOC103: Function `override_deployment_info`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the docstring but not in the function signature: [app_name: ].
0 commit comments