Skip to content

Commit 4197b85

Browse files
committed
removing eslint from check dashboard format
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
1 parent 30eb5b3 commit 4197b85

File tree

5 files changed

+9
-14
lines changed

5 files changed

+9
-14
lines changed

ci/lint/check-dashboard-format.sh

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33

44
set -euxo pipefail
55

6-
FILENAMES=("$@")
6+
ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE:-$0}")" || exit; pwd)/.."
7+
WORKSPACE_DIR="${ROOT_DIR}/.."
8+
9+
cd "${WORKSPACE_DIR}"/python/ray/dashboard/client || exit
10+
711
npm ci
812
FILENAMES=($(find src -name "*.ts" -or -name "*.tsx"))
9-
node_modules/.bin/eslint --max-warnings 0 "${FILENAMES[@]}"
13+
node_modules/.bin/prettier --check "${FILENAMES[@]}"
14+
node_modules/.bin/prettier --check public/index.html

python/ray/dashboard/client/src/App.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,13 @@ import {
5757
import { TaskPage } from "./pages/task/TaskPage";
5858
import { getNodeList } from "./service/node";
5959
import { lightTheme } from "./theme";
60-
//adding comment
60+
6161
dayjs.extend(duration);
6262

6363
// lazy loading fro prevent loading too much code at once
6464
const Actors = React.lazy(() => import("./pages/actor"));
6565
const CMDResult = React.lazy(() => import("./pages/cmd/CMDResult"));
66+
6667
// a global map for relations
6768
export type GlobalContextType = {
6869
nodeMap: { [key: string]: string };

python/ray/dashboard/client/src/pages/exception/Loading.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,3 @@ const fn: ReactNode = (
1919
);
2020

2121
export default fn;
22-
23-
export const testingsssss

python/ray/dashboard/client/src/service/data.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,3 @@ import { get } from "./requestHandlers";
44
export const getDataDatasets = (jobId: string) => {
55
return get<DatasetResponse>(`api/data/datasets/${jobId}`);
66
};
7-
8-
export testdata = ""

python/ray/dashboard/client/src/type/raylet.d.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@ type LabelMap = {
1414
[key: string]: string;
1515
};
1616

17-
type unused = {
18-
19-
}
20-
21-
type unused2 = {
22-
}r
23-
2417
export type Raylet = {
2518
numWorkers: number;
2619
pid: number;

0 commit comments

Comments
 (0)