Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default docker image (and all autoscaler images) does not support rllib #12390

Closed
richardliaw opened this issue Nov 25, 2020 · 6 comments · Fixed by #12703
Closed

Default docker image (and all autoscaler images) does not support rllib #12390

richardliaw opened this issue Nov 25, 2020 · 6 comments · Fixed by #12703
Assignees
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks

Comments

@richardliaw
Copy link
Contributor

What is the problem?

Got:

    from ray.rllib.models.preprocessors import get_preprocessor, \
  File "/root/anaconda3/lib/python3.7/site-packages/ray/rllib/models/preprocessors.py", line 2, in <module>
    import cv2
  File "/root/anaconda3/lib/python3.7/site-packages/cv2/__init__.py", line 5, in <module>
    from .cv2 import *
ImportError: libGL.so.1: cannot open shared object file: No such file or directory

when running:

rllib train --run=PPO --env=Pong-v0 --config='{"num_workers": 16, "num_sgd_iter": 1}' --num-samples=10000 --stop='{"timesteps_total": 1}' --ray-address=auto

workaround: conda-forge/pygridgen-feedstock#10

cc @ericl @sven1977 @ijrsvt

@richardliaw richardliaw added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 25, 2020
@ijrsvt
Copy link
Contributor

ijrsvt commented Nov 25, 2020

@richardliaw Which images (ray, ray-ml, autoscaler) and which tags (nightly, latest)

@richardliaw
Copy link
Contributor Author

ah, i see - i ran rayproject/ray:latest; perhaps instead, it would be good to add a reference to ray-ml this explicitly in all of the example yamls.

@ericl ericl added enhancement Request for new feature and/or capability tune Tune-related issues and removed bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 8, 2020
@ericl
Copy link
Contributor

ericl commented Dec 8, 2020

@ijrsvt can you change the yamls to ray-ml by default?

@ericl ericl added P1 Issue that should be fixed within a few weeks and removed tune Tune-related issues labels Dec 8, 2020
@ijrsvt
Copy link
Contributor

ijrsvt commented Dec 8, 2020

@ericl I'm okay with doing this--my only concern is that it will slow down the pull time.

@ericl
Copy link
Contributor

ericl commented Dec 8, 2020

Can you add the original image as a second line with a comment as a hint to the user? e.g.

image: ray-ml:latest
# image: ray:latest   # use this one if you don't need ML dependencies, it's faster to pull

@ijrsvt
Copy link
Contributor

ijrsvt commented Dec 8, 2020

@ericl Great idea!! :) Will do ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants