Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 4.0.0 build failing #14475

Closed
2 tasks done
viotemp1 opened this issue Mar 3, 2021 · 4 comments
Closed
2 tasks done

bazel 4.0.0 build failing #14475

viotemp1 opened this issue Mar 3, 2021 · 4 comments
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@viotemp1
Copy link
Contributor

viotemp1 commented Mar 3, 2021

What is the problem?

bazel build -c fastbuild //:ray_pkg failing

Ray version and other system information (Python version, TensorFlow version, OS):
git origin/master

Reproduction (REQUIRED)

I followed the steps from https://docs.ray.io/en/master/development.html
Fast, Debug, and Optimized Builds

Error is
DEBUG: /home/.../git/ray/bazel/ray_deps_setup.bzl:63:14: No implicit mirrors used because urls were explicitly provided
ERROR: /home/.../.cache/bazel/bazel.../3d6f788daadb4d2ddf971c3424fdc02c/external/com_google_protobuf/BUILD:873:21: in proto_lang_toolchain rule @com_google_protobuf//:cc_toolchain: '@com_google_protobuf//:cc_toolchain' does not have mandatory provider 'ProtoInfo'.
ERROR: Analysis of target '//:ray_pkg' failed; build aborted: Analysis of target '@com_google_protobuf//:cc_toolchain' failed
INFO: Elapsed time: 0.252s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)

bazel --version
bazel 4.0.0

  • I have verified my script runs in a clean environment and reproduces the issue.
  • I have verified the issue also occurs with the latest wheels.
@viotemp1 viotemp1 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 3, 2021
@viotemp1
Copy link
Contributor Author

viotemp1 commented Mar 4, 2021

made it finally following the diff from bazelbuild/bazel#12887
Maybe is not the right solution, there are come warnings when building...

I modified WORKSPACE like this.

diff --git a/WORKSPACE b/WORKSPACE
index 35038a3a1..21834f5c0 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -1,5 +1,20 @@
workspace(name = "com_github_ray_project_ray")

+load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
+
+git_repository(

+load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")
+rules_proto_dependencies()
+rules_proto_toolchains()
+
+load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
+protobuf_deps()
+
load("//bazel:ray_deps_setup.bzl", "ray_deps_setup")

ray_deps_setup()

@viotemp1
Copy link
Contributor Author

viotemp1 commented Mar 8, 2021

I actually have some errors - from time to time. Not sure is this compilation is the problem. I found the same issue with ray-nightly also

(pid=gcs_server) [2021-03-08 16:35:53,918 C 124910 124910] gcs_placement_group_scheduler.cc:202: Check failed: it != placement_group_leasing_in_progress_.end()
(pid=gcs_server) [2021-03-08 16:35:53,918 E 124910 124910] logging.cc:435: *** Aborted at 1615214153 (unix time) try "date -d @1615214153" if you are using GNU date ***
(pid=gcs_server) [2021-03-08 16:35:53,919 E 124910 124910] logging.cc:435: PC: @ 0x0 (unknown)
(pid=gcs_server) [2021-03-08 16:35:53,919 E 124910 124910] logging.cc:435: *** SIGABRT (@0x3e80001e7ee) received by PID 124910 (TID 0x7f8ad59d9800) from PID 124910; stack trace: ***
(pid=gcs_server) [2021-03-08 16:35:53,919 E 124910 124910] logging.cc:435: @ 0x55d6d32a6cbf google::(anonymous namespace)::FailureSignalHandler()
(pid=gcs_server) [2021-03-08 16:35:53,919 E 124910 124910] logging.cc:435: @ 0x7f8ad5f3b3c0 (unknown)
(pid=gcs_server) [2021-03-08 16:35:53,919 E 124910 124910] logging.cc:435: @ 0x7f8ad5a2418b gsignal
(pid=gcs_server) [2021-03-08 16:35:53,919 E 124910 124910] logging.cc:435: @ 0x7f8ad5a03859 abort
(pid=gcs_server) [2021-03-08 16:35:53,920 E 124910 124910] logging.cc:435: @ 0x55d6d3296005 ray::SpdLogMessage::Flush()
(pid=gcs_server) [2021-03-08 16:35:53,921 E 124910 124910] logging.cc:435: @ 0x55d6d329603d ray::RayLog::~RayLog()
(pid=gcs_server) [2021-03-08 16:35:53,921 E 124910 124910] logging.cc:435: @ 0x55d6d309f414 ray::gcs::GcsPlacementGroupScheduler::MarkScheduleCancelled()
(pid=gcs_server) [2021-03-08 16:35:53,922 E 124910 124910] logging.cc:435: @ 0x55d6d30afa94 ray::gcs::GcsPlacementGroupManager::RemovePlacementGroup()
(pid=gcs_server) [2021-03-08 16:35:53,923 E 124910 124910] logging.cc:435: @ 0x55d6d30b063f ray::gcs::GcsPlacementGroupManager::HandleRemovePlacementGroup()
(pid=gcs_server) [2021-03-08 16:35:53,923 E 124910 124910] logging.cc:435: @ 0x55d6d30073c2 _ZN5boost4asio6detail18completion_handlerIZN3ray3rpc14ServerCallImplINS4_35PlacementGroupInfoGcsServiceHandlerENS4_27RemovePlacementGroupRequestENS4_25RemovePlacementGroupReplyEE13HandleRequestEvEUlvE_E11do_completeEPvPNS1_19scheduler_operationERKNS_6system10error_codeEm
(pid=gcs_server) [2021-03-08 16:35:53,924 E 124910 124910] logging.cc:435: @ 0x55d6d33f7771 boost::asio::detail::scheduler::do_run_one()
(pid=gcs_server) [2021-03-08 16:35:53,925 E 124910 124910] logging.cc:435: @ 0x55d6d33f8e89 boost::asio::detail::scheduler::run()
(pid=gcs_server) [2021-03-08 16:35:53,926 E 124910 124910] logging.cc:435: @ 0x55d6d33faf97 boost::asio::io_context::run()
(pid=gcs_server) [2021-03-08 16:35:53,926 E 124910 124910] logging.cc:435: @ 0x55d6d2f87417 main
(pid=gcs_server) [2021-03-08 16:35:53,926 E 124910 124910] logging.cc:435: @ 0x7f8ad5a050b3 __libc_start_main
(pid=gcs_server) [2021-03-08 16:35:53,928 E 124910 124910] logging.cc:435: @ 0x55d6d2f9a577 (unknown)

@tisonkun
Copy link
Contributor

tisonkun commented Mar 9, 2021

It seems the same issue as #14117

@viotemp1
Copy link
Contributor Author

True, I'll watch that Issue. This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

2 participants