Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune output] Create a new tune output layout where the trial status table is sticky at the bottom using rich live table #33009

Closed
xwjiang2010 opened this issue Mar 3, 2023 · 4 comments
Closed

[tune output] Create a new tune output layout where the trial status table is sticky at the bottom using rich live table #33009

xwjiang2010 opened this issue Mar 3, 2023 · 4 comments
Assignees
@xwjiang2010
Labels
P1 Issue that should be fixed within a few weeks ray-team-created Ray Team created tune Tune-related issues
Milestone
Tune Console Output

Comments

@xwjiang2010
Copy link
Contributor

What happened + What you expected to happen

requirements:

  • should be feature flagged. If users desire, they can easily disable it and go back to the originals.
  • the table should contain the information and reasonably styled as aligned with @scottsun94
  • the rendering itself should not have too much performance overhead. watch out for that!
  • tdb if rich should be a hard requirement for tune.

Versions / Dependencies

master

Reproduction script

NA

Issue Severity

Medium: It is a significant difficulty but I can work around it.
@xwjiang2010 xwjiang2010 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 3, 2023
@xwjiang2010
Copy link
Contributor Author

cc @matthewdeng @scottsun94

@xwjiang2010 xwjiang2010 added P0 Issues that should be fixed in short order tune Tune-related issues and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 3, 2023
@xwjiang2010 xwjiang2010 self-assigned this Mar 3, 2023
@xwjiang2010 xwjiang2010 added this to the Tune Console Output milestone Mar 3, 2023
@xwjiang2010
Copy link
Contributor Author

related discussion: Textualize/rich#2841
performance seems to be terminal dependent.

@ollie-iterators ollie-iterators mentioned this issue Mar 4, 2023
Closed
7 tasks
@xwjiang2010
Copy link
Contributor Author

@matthewdeng @scottsun94
A few things:

  1. we will hide this behind a feature flag and off by default
  2. The rich sticky table at the bottom actually makes ipdb experience worse. Is that ok or is this a blocker? @matthewdeng

@xwjiang2010 xwjiang2010 added P1 Issue that should be fixed within a few weeks and removed P0 Issues that should be fixed in short order labels Mar 8, 2023
@xwjiang2010
Copy link
Contributor Author

Talked with @matthewdeng
We don't prioritize ipdb experience for 2.4.
If user wants the current ipdb experience they can switch back the feature flag to off (more reason for #1 above).

@xwjiang2010 xwjiang2010 removed the bug Something that is supposed to be working; but isn't label Mar 8, 2023
@Yard1 Yard1 added the ray-team-created Ray Team created label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xwjiang2010 xwjiang2010

Labels
P1 Issue that should be fixed within a few weeks ray-team-created Ray Team created tune Tune-related issues
Projects
None yet
Milestone
Tune Console Output
Development

No branches or pull requests
2 participants
@Yard1 @xwjiang2010