Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][docs infra] copy and paste of code example with line no.s copies line no.s #39652

Open
angelinalg opened this issue Sep 13, 2023 · 4 comments
Labels
docs An issue or change related to documentation P1 Issue that should be fixed within a few weeks

Comments

@angelinalg
Copy link
Contributor

angelinalg commented Sep 13, 2023

Description

When I use the mouse and drag function to copy and paste a code example that has line numbers, it copies the line numbers as well. This used to work: #34617

It seems to not work for this code example: https://docs.ray.io/en/releases-2.6.3/serve/model_composition.html#model-composition-example

cc: @peytondmurray @zcin @shrekris-anyscale

Screen.Recording.2023-09-13.at.3.49.08.PM.mov

Link

https://docs.ray.io/en/releases-2.6.3/serve/model_composition.html#model-composition-example

@angelinalg angelinalg added P1 Issue that should be fixed within a few weeks docs An issue or change related to documentation labels Sep 13, 2023
@peytondmurray peytondmurray self-assigned this Sep 15, 2023
@peytondmurray
Copy link
Contributor

Status update for this issue:

I've had no luck reproducing this issue locally both on FF and Chrome. The linked PR explicitly adds CSS rules which forbid copying of the line numbers, but from discussions with @angelinalg the fix didn't seem to do the trick. Putting this effort on hold for now due to difficulty in reproducing the issue.

@angelinalg
Copy link
Contributor Author

The same problem happens when you use the "copy" button, per this issue: #40936

@angelinalg
Copy link
Contributor Author

Checking with @MattEWeber to see if he has ideas on how to troubleshoot. He is able to reproduce the "copy" button behavior.

@peytondmurray
Copy link
Contributor

@angelinalg Can you try to replicate this with the new docs?

@peytondmurray peytondmurray removed their assignment Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants