Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test linux://rllib:learning_tests_pendulum_ppo is flaky #47434

Closed
can-anyscale opened this issue Aug 30, 2024 · 13 comments
Closed

CI test linux://rllib:learning_tests_pendulum_ppo is flaky #47434

can-anyscale opened this issue Aug 30, 2024 · 13 comments
Assignees
@sven1977
Labels
bug Something that is supposed to be working; but isn't ci-test flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ P1 Issue that should be fixed within a few weeks ray-test-bot Issues managed by OSS test policy rllib RLlib related issues stability

Comments

@can-anyscale
Copy link
Collaborator

CI test linux://rllib:learning_tests_pendulum_ppo is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6087#0191a512-f573-4d83-999e-fe176135ac78
- https://buildkite.com/ray-project/postmerge/builds/6087#0191a4e8-13f4-45a1-9943-c5f6a7b5d80d

DataCaseName-linux://rllib:learning_tests_pendulum_ppo-END
Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ci-test flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy rllib RLlib related issues stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels Aug 30, 2024
@can-anyscale
Copy link
Collaborator Author

Blamed commit: a967a35 found by bisect job https://buildkite.com/ray-project/release-tests-bisect/builds/1510

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6091#0191a5c3-26a9-4ff8-aca7-83af3d709fa7

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6093#0191a6f9-b0fa-4f1f-9a77-ff847da59281

@can-anyscale can-anyscale changed the title CI test linux://rllib:learning_tests_pendulum_ppo is consistently_failing CI test linux://rllib:learning_tests_pendulum_ppo is flaky Sep 2, 2024
@can-anyscale can-anyscale reopened this Sep 2, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://rllib:learning_tests_pendulum_ppo is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6097#0191b121-39df-4434-81cf-5b2b1c99be3f
- https://buildkite.com/ray-project/postmerge/builds/6093#0191a6d4-cb23-41ad-9961-b109919ccc4d
- https://buildkite.com/ray-project/postmerge/builds/6087#0191a512-f573-4d83-999e-fe176135ac78
- https://buildkite.com/ray-project/postmerge/builds/6087#0191a4e8-13f4-45a1-9943-c5f6a7b5d80d

DataCaseName-linux://rllib:learning_tests_pendulum_ppo-END
Managed by OSS Test Policy

@can-anyscale can-anyscale removed the weekly-release-blocker Issues that will be blocking Ray weekly releases label Sep 4, 2024
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6150#0191c47f-cb19-440c-98f1-70f32413ff08

@can-anyscale can-anyscale changed the title CI test linux://rllib:learning_tests_pendulum_ppo is flaky CI test linux://rllib:learning_tests_pendulum_ppo is consistently_failing Sep 6, 2024
@can-anyscale can-anyscale reopened this Sep 6, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://rllib:learning_tests_pendulum_ppo is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6157#0191c4aa-1941-4489-973a-ca4680faef80
- https://buildkite.com/ray-project/postmerge/builds/6157#0191c4aa-1941-4489-973a-ca4680faef80
- https://buildkite.com/ray-project/postmerge/builds/6146#0191c3fa-6bee-4ba8-bcbe-a3723a2287a7
- https://buildkite.com/ray-project/postmerge/builds/6148#0191c3ce-b797-41a2-973c-62ae07a2c0c1
- https://buildkite.com/ray-project/postmerge/builds/6144#0191c3d7-51ca-499e-8f4e-7afa22aaac5e

DataCaseName-linux://rllib:learning_tests_pendulum_ppo-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Blamed commit: d8a85c5 found by bisect job https://buildkite.com/ray-project/release-tests-bisect/builds/1531

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6158#0191c4c7-7c47-440f-9f4c-b957660d40b2

@can-anyscale can-anyscale changed the title CI test linux://rllib:learning_tests_pendulum_ppo is consistently_failing CI test linux://rllib:learning_tests_pendulum_ppo is flaky Sep 6, 2024
@can-anyscale can-anyscale reopened this Sep 6, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://rllib:learning_tests_pendulum_ppo is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6157#0191c4aa-1941-4489-973a-ca4680faef80
- https://buildkite.com/ray-project/postmerge/builds/6157#0191c4aa-1941-4489-973a-ca4680faef80
- https://buildkite.com/ray-project/postmerge/builds/6146#0191c3fa-6bee-4ba8-bcbe-a3723a2287a7
- https://buildkite.com/ray-project/postmerge/builds/6148#0191c3ce-b797-41a2-973c-62ae07a2c0c1
- https://buildkite.com/ray-project/postmerge/builds/6144#0191c3d7-51ca-499e-8f4e-7afa22aaac5e

DataCaseName-linux://rllib:learning_tests_pendulum_ppo-END
Managed by OSS Test Policy

@simonsays1980 simonsays1980 added P0 Issues that should be fixed in short order and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Sep 11, 2024
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6270#0191ec9f-a57f-4a17-97c8-35f6a7da90f5

@can-anyscale can-anyscale reopened this Sep 13, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://rllib:learning_tests_pendulum_ppo is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6271#0191ed02-1b0d-438d-99bf-554d26330923
- https://buildkite.com/ray-project/postmerge/builds/6268#0191e9c9-5cb8-442a-b5ab-6fb36ce14b75
- https://buildkite.com/ray-project/postmerge/builds/6267#0191e972-d9cb-404e-a59f-f726d4b70b48
- https://buildkite.com/ray-project/postmerge/builds/6266#0191e94e-f8a9-429f-ab25-955d8aa22eec
- https://buildkite.com/ray-project/postmerge/builds/6266#0191e94e-f8a9-429f-ab25-955d8aa22eec

DataCaseName-linux://rllib:learning_tests_pendulum_ppo-END
Managed by OSS Test Policy

@sven1977 sven1977 added P1 Issue that should be fixed within a few weeks and removed P0 Issues that should be fixed in short order labels Sep 16, 2024
@sven1977
Copy link
Contributor

Downprio'd to P1. This instability should get fixed with doing batch shuffling for PPO.
PR about to be merged (more testing pending).
#47458

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6301#019200bf-5bed-4935-91ed-8dce3589213d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sven1977 sven1977

Labels
bug Something that is supposed to be working; but isn't ci-test flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ P1 Issue that should be fixed within a few weeks ray-test-bot Issues managed by OSS test policy rllib RLlib related issues stability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonsays1980 @sven1977 @can-anyscale