Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled-graphs] Revisit the definition of upstream / downstream definitions in DAG and RayCG #48520

Open
kevin85421 opened this issue Nov 3, 2024 · 0 comments
Labels
compiled-graphs core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical

Comments

@kevin85421
Copy link
Member

kevin85421 commented Nov 3, 2024

Description

Currently, the DAG assumes that all DAGNodes in args, kwargs, and other_args_to_resolve are upstream nodes (code). However, Ray Compiled Graphs builds the upstream/downstream relationship based only on args.

If other_args_to_resolve contains DAGNodes which don't belong to args, traditional DAG and RayCG will have different understanding about the DAG graph.

Use case

No response

@kevin85421 kevin85421 added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared compiled-graphs and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 3, 2024
@jjyao jjyao added P2 Important issue, but not time-critical and removed P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiled-graphs core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical
Projects
None yet
Development

No branches or pull requests

2 participants