[core][compiled-graphs] Revisit the definition of upstream / downstream definitions in DAG and RayCG #48520
Labels
compiled-graphs
core
Issues that should be addressed in Ray Core
enhancement
Request for new feature and/or capability
P2
Important issue, but not time-critical
Description
Currently, the DAG assumes that all DAGNodes in
args
,kwargs
, andother_args_to_resolve
are upstream nodes (code). However, Ray Compiled Graphs builds the upstream/downstream relationship based only onargs
.If
other_args_to_resolve
containsDAGNodes
which don't belong toargs
, traditional DAG and RayCG will have different understanding about the DAG graph.DAGNodes
insideother_args_to_resolve
if they don't belong toargs
(example: [core][compiled-graphs] Don't persist input_nodes in _CollectiveOperation to avoid wrong understanding about DAGs #48463) because it is possible to cause issues if we change some assumptions in RayCG in the future (example: [core][compiled-graph] Support a list of DAGNodes as an arg #48045 (comment)).dag_node.py
, so all DAGNodes inside the new field will not be considered as upstream nodes.Use case
No response
The text was updated successfully, but these errors were encountered: