Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] logging_config specified in serve.run is not propagated cluster-wide #48652

Closed
paul-twelvelabs opened this issue Nov 8, 2024 · 0 comments · Fixed by #48790
Closed
Assignees
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue

Comments

@paul-twelvelabs
Copy link

Description

Specifying logging_config in serve.run(..., logging_config={...}) does not configure logging for the cluster, as is expected. This is because we don't propagate logging_config to .serve_start(...) here:

https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py#L475-L477

A simple workaround for now is,

logging_config = {"log_level": "..."}
serve.start(logging_config=logging_config)
serve.run(logging_config=logging_config)

Use case

This issue arose when trying to configure Serve logging holistically for tests.

@paul-twelvelabs paul-twelvelabs added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 8, 2024
@jcotant1 jcotant1 added the serve Ray Serve Related Issue label Nov 8, 2024
@akshay-anyscale akshay-anyscale added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants