Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Spot preemption related retries do not count towards the max retries #50640

Open
jjyao opened this issue Feb 16, 2025 · 1 comment
Open

[Core] Spot preemption related retries do not count towards the max retries #50640

jjyao opened this issue Feb 16, 2025 · 1 comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks

Comments

@jjyao
Copy link
Collaborator

jjyao commented Feb 16, 2025

Description

User is seeing spot instance preemption and it is causing their Jobs to fail due to them exhausting their max_restarts and max_task_retries. Ideally they want to retry infinitely for spot preemption caused failures.

Use case

No response
@jjyao jjyao added core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Feb 16, 2025
@robertnishihara
Copy link
Collaborator

Not sure we should actually do this. For now, I suggest working around just by increasing max_restarts and max_task_retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertnishihara @jjyao