Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Split raylet cython file into multiple files #51080

Open
dentiny opened this issue Mar 5, 2025 · 1 comment
Open

[core] Split raylet cython file into multiple files #51080

dentiny opened this issue Mar 5, 2025 · 1 comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray help-wanted P2 Important issue, but not time-critical

Comments

@dentiny
Copy link
Contributor

dentiny commented Mar 5, 2025

Description

Our raylet cython file is a giant: https://github.com/ray-project/ray/blob/master/python/ray/_raylet.pyx, which spans for over 5K LOC.

Two issues:

  • (minor) the file is too big, and hard to manage (i.e. add new code, delete old code, and glance over)
  • (major) a single file is compiled in single thread for compilers; for now it takes 5-10 minutes every time to rebuild the target

Proposed solution:

  • Split the raylet cython file into smaller files
  • cython here is used to expose C++ impl for python usage, so all imports should be updated accordingly

This issue doesn't require people to split the target cleanly, even separating several functions out is good.

Use case

No response

@dentiny dentiny added core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray help-wanted P2 Important issue, but not time-critical labels Mar 5, 2025
@nadongjun
Copy link
Contributor

@dentiny I’d like to take this on—please assign it to me if possible. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray help-wanted P2 Important issue, but not time-critical
Projects
None yet
Development

No branches or pull requests

2 participants