Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move to bzlmod for handling dependencies #51228

Open
dayshah opened this issue Mar 10, 2025 · 0 comments
Open

[core] Move to bzlmod for handling dependencies #51228

dayshah opened this issue Mar 10, 2025 · 0 comments
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared

Comments

@dayshah
Copy link
Contributor

dayshah commented Mar 10, 2025

Description

Currently Ray uses the outdated WORKSPACE / http_archive way to get dependencies and build them. For example, see https://github.com/ray-project/ray/blob/master/bazel/ray_deps_setup.bzl used in https://github.com/ray-project/ray/blob/master/WORKSPACE. We shouldn't define dependency builds like this, ex. for nlohmann_json we have https://github.com/ray-project/ray/blob/master/bazel/nlohmann_json.BUILD and

http_archive(
name = "nlohmann_json",
strip_prefix = "json-3.9.1",
urls = ["https://github.com/nlohmann/json/archive/v3.9.1.tar.gz"],
sha256 = "4cf0df69731494668bdd6460ed8cb269b68de9c19ad8c27abc24cd72605b2d5b",
build_file = "@com_github_ray_project_ray//bazel:nlohmann_json.BUILD",
)
.

Instead we should use migrate to bzlmod and use the bazel central registry as almost all of our dependencies can be found there. Ex. https://registry.bazel.build/modules/nlohmann_json. This will make dependency builds more consistent and make upgrades way less painful.

This is the guide to do the migration to bzlmod https://bazel.build/external/migration, ideally we should go with the gradual migration route and do each dependency one by one.

Use case

No response

@dayshah dayshah added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared core Issues that should be addressed in Ray Core and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared
Projects
None yet
Development

No branches or pull requests

1 participant