Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken with current Master-Version of ImGui #78

Closed
TillWege opened this issue Oct 8, 2024 · 1 comment
Closed

Build is broken with current Master-Version of ImGui #78

TillWege opened this issue Oct 8, 2024 · 1 comment

Comments

@TillWege
Copy link

TillWege commented Oct 8, 2024

The Commit "92b94980c69ff3d3d7f5dc30c1c19abfb72db47e" (ocornut/imgui#1641) seems to have broken the build process for rlImGui.

Building with the mentioned commit leads to the following error:

❯ make
[ 55%] Built target glfw
[ 76%] Built target raylib
[ 78%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/imgui-src/imgui.cpp.o
[ 81%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/imgui-src/imgui_demo.cpp.o
[ 84%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/imgui-src/imgui_draw.cpp.o
[ 86%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/imgui-src/imgui_tables.cpp.o
[ 89%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/imgui-src/imgui_widgets.cpp.o
[ 92%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/imgui-src/misc/cpp/imgui_stdlib.cpp.o
[ 94%] Building CXX object CMakeFiles/raylibcaster.dir/_deps/rlimgui-src/rlImGui.cpp.o
/.../build/_deps/rlimgui-src/rlImGui.cpp:87:23: error: incompatible pointer to integer conversion assigning to 'ImTextureID' (aka 'unsigned long long') from 'Texture2D *' (aka 'Texture *')
   87 |     io.Fonts->TexID = fontTexture;
      |                       ^~~~~~~~~~~
/.../build/_deps/rlimgui-src/rlImGui.cpp:689:13: error: no matching function for call to 'ImGuiRenderTriangles'
  689 |             ImGuiRenderTriangles(cmd.ElemCount, cmd.IdxOffset, commandList->IdxBuffer, commandList->VtxBuffer, cmd.TextureId);
      |             ^~~~~~~~~~~~~~~~~~~~
/.../build/_deps/rlimgui-src/rlImGui.cpp:196:13: note: candidate function not viable: no known conversion from 'const ImTextureID' (aka 'const unsigned long long') to 'void *' for 5th argument
  196 | static void ImGuiRenderTriangles(unsigned int count, int indexStart, const ImVector<ImDrawIdx>& indexBuffer, const ImVector<ImDrawVert>& vertBuffer, void* texturePtr)
      |             ^                                                                                                                                        ~~~~~~~~~~~~~~~~
2 errors generated.
make[2]: *** [CMakeFiles/raylibcaster.dir/_deps/rlimgui-src/rlImGui.cpp.o] Error 1
make[1]: *** [CMakeFiles/raylibcaster.dir/all] Error 2
make: *** [all] Error 2
@JeffM2501
Copy link
Contributor

Fixed in c730325
Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants