Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Rails 5 support! #168

Open
eschartner opened this issue Jul 5, 2016 · 6 comments
Open

Rails 5 support! #168

eschartner opened this issue Jul 5, 2016 · 6 comments

Comments

@eschartner
Copy link

eschartner commented Jul 5, 2016

Is there a reason why the Rails version has to be smaller than 4.3.0 ?

Because of this restriction I cannot upgrade to Rails 5.

Same issue for casino-activerecord_authenticator (activerecord dependency).

@luxflux
Copy link
Member

luxflux commented Sep 16, 2016

The reason is that it's not tested against a Rails 5 app. Does it work for you if you loosen the dependencies?

@AjayBarot
Copy link

@luxflux : I added rails 5 dependency and this is test result.

Finished in 13.1 seconds (files took 7.54 seconds to load)
294 examples, 37 failures

I will let you know once i am done with these failed specs.

@luxflux
Copy link
Member

luxflux commented Oct 5, 2016

Great, @AjayBarot! Looking forward to the PR 😄

@AjayBarot
Copy link

AjayBarot commented Oct 19, 2016

@luxflux : Please review this PR and I updated devise_cas_authenticatable too with rails 5. Please give your suggestion regarding this issue too. devise_cas_authenticatable

Thanks

@jmmastey
Copy link

jmmastey commented Jun 9, 2017

@luxflux (cc @pencil I think?) checking in. I see this old conversation and PR with broken tests.

I've got a green running branch for Rails 5.0 and Rails 5.1 (it's a small number of actual changes). Is there interest in me generating a PR for it? I'd rather not run a hacked copy of CASino for my client's code.

It's here if that's most interesting:
https://github.com/rbCAS/CASino/compare/master...jmmastey:rails-5?expand=1

Thanks!

@joelvh
Copy link
Contributor

joelvh commented Nov 16, 2017

@jmmastey we've got a Rails 5.0 branch going too. I just created a PR for it here: #192

As mentioned in the other issue about maintainers (#189), we'll aim to maintain on our branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants