-
Notifications
You must be signed in to change notification settings - Fork 187
Rails 5 support! #168
Comments
The reason is that it's not tested against a Rails 5 app. Does it work for you if you loosen the dependencies? |
@luxflux : I added rails 5 dependency and this is test result.
I will let you know once i am done with these failed specs. |
Great, @AjayBarot! Looking forward to the PR 😄 |
@luxflux : Please review this PR and I updated Thanks |
@luxflux (cc @pencil I think?) checking in. I see this old conversation and PR with broken tests. I've got a green running branch for Rails 5.0 and Rails 5.1 (it's a small number of actual changes). Is there interest in me generating a PR for it? I'd rather not run a hacked copy of CASino for my client's code. It's here if that's most interesting: Thanks! |
Is there a reason why the Rails version has to be smaller than 4.3.0 ?
Because of this restriction I cannot upgrade to Rails 5.
Same issue for casino-activerecord_authenticator (activerecord dependency).
The text was updated successfully, but these errors were encountered: