-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon causes Storybook 7 to hang/load for a long time and then crash #45
Comments
Hi @elisehein! Thanks for reporting this. I haven't tested the addon with Storybook 7 yet (been waiting for the stable release), but I'll give it a try soon and report back here. |
@rbardini Any update on this one? Storybook 7 is in RC now and I would LOVE to get this addon working in it. From what I can tell, it'll work fine only if I pass in playroom code to my stories. If it tries to use the story source, it pulls in all my themes as well as |
@rbardini Storybook 7 is now in stable release! Any chance we could get this plugin upgraded to support it? |
@noranda I'll try to release a new major version supporting Storybook 7.0 sometime next week. |
@rbardini Fantastic! Looking forward to it! |
@rbardini Storybook just released this addon migration guide for Storybook 7 that might be of some help! |
🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@rbardini Thanks for this! |
No problem! Sorry for the delay, it took more time than I expected. Let me know if you find any issues! |
After upgrading to Storybook 7.0.0-beta.47, enabling the playroom addon (v3.0.2) causes Storybook to load stories for a long time and eventually crash. There are no errors reported back from
storybook dev
orstorybook build
, and no errors in the browser console.After a while it crashes at the following line:
The text was updated successfully, but these errors were encountered: