Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon causes Storybook 7 to hang/load for a long time and then crash #45

Closed
elisehein opened this issue Feb 15, 2023 · 9 comments · Fixed by #46
Closed

Addon causes Storybook 7 to hang/load for a long time and then crash #45

elisehein opened this issue Feb 15, 2023 · 9 comments · Fixed by #46
Assignees
Labels
bug Something isn't working released

Comments

@elisehein
Copy link

elisehein commented Feb 15, 2023

After upgrading to Storybook 7.0.0-beta.47, enabling the playroom addon (v3.0.2) causes Storybook to load stories for a long time and eventually crash. There are no errors reported back from storybook dev or storybook build, and no errors in the browser console.

CleanShot 2023-02-15 at 11 29 04@2x

After a while it crashes at the following line:

CleanShot 2023-02-15 at 11 39 39@2x

@rbardini rbardini added the bug Something isn't working label Feb 20, 2023
@rbardini rbardini self-assigned this Feb 20, 2023
@rbardini
Copy link
Owner

Hi @elisehein! Thanks for reporting this. I haven't tested the addon with Storybook 7 yet (been waiting for the stable release), but I'll give it a try soon and report back here.

@noranda
Copy link

noranda commented Mar 31, 2023

@rbardini Any update on this one? Storybook 7 is in RC now and I would LOVE to get this addon working in it.

From what I can tell, it'll work fine only if I pass in playroom code to my stories. If it tries to use the story source, it pulls in all my themes as well as <No Display Name /> and fails.

@noranda
Copy link

noranda commented Apr 4, 2023

@rbardini Storybook 7 is now in stable release! Any chance we could get this plugin upgraded to support it?

@rbardini
Copy link
Owner

rbardini commented Apr 5, 2023

@noranda I'll try to release a new major version supporting Storybook 7.0 sometime next week.

@noranda
Copy link

noranda commented Apr 6, 2023

@rbardini Fantastic! Looking forward to it!

@noranda
Copy link

noranda commented Apr 6, 2023

@rbardini Storybook just released this addon migration guide for Storybook 7 that might be of some help!

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@noranda
Copy link

noranda commented Apr 25, 2023

@rbardini Thanks for this!

@rbardini
Copy link
Owner

No problem! Sorry for the delay, it took more time than I expected. Let me know if you find any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants