Skip to content
This repository has been archived by the owner on Apr 25, 2022. It is now read-only.

Generator hangs on README exists #24

Closed
joehannes-zz opened this issue Jun 22, 2017 · 4 comments
Closed

Generator hangs on README exists #24

joehannes-zz opened this issue Jun 22, 2017 · 4 comments

Comments

@joehannes-zz
Copy link

If a README exists I'm prompted what to do but the generator hangs instead of accepting input

@rblopes
Copy link
Owner

rblopes commented Jun 22, 2017

Can you confirm that only happens when there is a README.md file in the working folder? Does that happen when any other file that may get overwritten by the generator?

Also I need to know your OS, and which versions of Node.js and npm (or Yarn) you're using.

@joehannes-zz
Copy link
Author

I can confirm it started working when I had the idea the existing README is the ... and removed it.
I actually tried it again now and plaid with it, it also hangs on other files if they exist (tested: package.json)

how to reproduce ... simply run the generator twice in the same dir, you may ctrl+c the npm install

OS: Ubuntu 17.04
Node: 8.1.0
npm: 5.0.3

Cheers

@rblopes
Copy link
Owner

rblopes commented Jun 22, 2017

I'll request you to upgrade to Node.js v8.1.2 then. Your issue seems related to a regression in the readline module found recently (sources: 1, 2).


Edit: I tested both Node.js 8.1.0 and 8.1.2 and confirmed the problem only happens in 8.1.0.

@joehannes-zz
Copy link
Author

I can confirm that as well.
I updated to 8.1.2 and it started working :)
Thx

@rblopes rblopes closed this as completed Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants