Enable fade effects to work on transparent backgrounds by fixing "bad argument to blend" bug #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… argument to blend" bug
|
Hey thanks for the PR! 😄 Just so I understand the issue a bit better, what highlight group definition is causing this? I can't seem to reproduce this (I'm using a transparent background as well) and only get the return of |
|
Ahah figured it out, I have it set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm one of the troublemakers with a transparent background, the new updates with the fade effects were causing a bug for me:
Error running notification service: ...art/nvim-notify/lua/notify/service/buffer/highlights.lua:59: bad argument #2 to 'blend' (no value)Just required an extra conditional to see if the background color ends up at 'none' or ''. In case you're wondering, it still fades even though my background is transparent because I have active tmux panes highlighted a solid color to help identify the active pane, so when it's focused it's actually opaque (even though the vim background never is).