Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet based on ethereum transaction signatures #55

Closed
dckc opened this issue Dec 8, 2018 · 3 comments
Closed

wallet based on ethereum transaction signatures #55

dckc opened this issue Dec 8, 2018 · 3 comments

Comments

@dckc
Copy link
Collaborator

dckc commented Dec 8, 2018

We can use metamask in place of RSign if we make an analog to BasicWallet that uses RLP (recursive length prefix) in place of protobuf to serialize the signed parameters.

I think I have the tedious details prototyped:

https://github.com/dckc/RChain-API/blob/ethWallet/src/rlp.rho

https://github.com/dckc/RChain-API/blob/ethWallet/src/ethSig.rho

It relies on some new ByteArray methods, a couple of which I haven't written yet: rchain/rchain#1968

It would also depend on a "hitching post" for "find or create the eth-style wallet for eth address A".

cc @JoshOrndorff @cboscolo

@dckc
Copy link
Collaborator Author

dckc commented Dec 10, 2018

I think the ByteArray methods are complete: 9af5fa4 in rchain/rchain#1968

Interpolation on ByteArray makes the DER encoding stuff much nicer: bb08e15

@dckc
Copy link
Collaborator Author

dckc commented Dec 14, 2018

ethSig.rho has the findOrCreateWallet hitching post now (9631495)

sendTransaction can find the wallet to send from and have it verify the signature and find the wallet to send to. It can't yet transfer the funds because I haven't integrated real purses.

A little more rlp decoding (for nonce, value) is also TODO.

cc @edeykholt

@dckc
Copy link
Collaborator Author

dckc commented Dec 14, 2018

for follow-up, see #56

@dckc dckc closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant