Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build more robust sql batch parser #88

Closed
rdagumampan opened this issue May 8, 2020 · 1 comment
Closed

Build more robust sql batch parser #88

rdagumampan opened this issue May 8, 2020 · 1 comment

Comments

@rdagumampan
Copy link
Owner

rdagumampan commented May 8, 2020

An sql batch statements is a group of sql statements executed in a single call. In SqlServer, a batch scripts are group of statements in a single .sql file terminated by "GO". In Snowflake and other platforms, the terminator is a semicolon ";".

The current strategy is not robust enough to handle this and delegated the breakdown of statements to the platform implementation. It would be better to take this capability in Yuniql.Core, have some default BatchTerminator in the implementation of IDataService. The BatchTerminator can also be parameterized such as --batch-terminator GO or --batch-terminator ;

@rdagumampan rdagumampan added new idea help wanted You're welcome to work on it right away labels May 8, 2020
@rdagumampan rdagumampan added this to the vnext milestone May 8, 2020
@rdagumampan rdagumampan self-assigned this May 12, 2020
@rdagumampan rdagumampan added implementing and removed help wanted You're welcome to work on it right away labels May 12, 2020
@rdagumampan rdagumampan modified the milestones: vnext, v1.0 May 16, 2020
@rdagumampan
Copy link
Owner Author

rdagumampan commented May 18, 2020

Done. The better parser will be part of Yuniq.Extensibility project.
It will be be part of release v1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant