perf: compute intersection over indices

[jeswr]

Summary by CodeRabbit

• New Features

  • Introduced a new function to compute the intersection of two objects, enhancing data handling capabilities.
  • Updated the N3Store class to utilize the new intersection functionality in its merge process.

• Bug Fixes

  • Enhanced the logic to ensure accurate handling of graph data intersections within the N3Store.

• Tests

  • Added comprehensive tests for the intersection and union methods of the Store class, improving test coverage and reliability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new function called intersect in the N3Store.js file, which computes the intersection of two objects up to a specified depth. This function identifies matching keys and recursively determines the intersection of their values, returning a new object with intersecting keys or false if none are found. Additionally, the N3Store class has been modified to use this function in its merge method when merging with another N3Store instance. Corresponding tests have been added in N3Store-test.js to validate the functionality of intersection and union methods.

Changes

Files	Change Summary
src/N3Store.js	Added function intersect(s1, s2, depth = 4); modified merge method in N3Store class to utilize intersect.
test/N3Store-test.js	Added tests for intersection and union methods of Store class, validating behavior across multiple instances.

Poem

🐰 In the land of code where rabbits play,
New functions hop in, brightening the day!
Intersections dance, unions unite,
With tests all around, everything feels right.
So let’s celebrate, with a joyful cheer,
For the changes in code bring us all near! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f71ef64 and 7d086a4.

Files selected for processing (2)

• src/N3Store.js (2 hunks)
• test/N3Store-test.js (1 hunks)

Additional comments not posted (6)

src/N3Store.js (1)

920-931: Effective integration of intersect in N3Store.

The modifications to the N3Store class effectively utilize the new intersect function within the merge method. The checks for instance type and _entityIndex matching are appropriately placed to ensure correct operation. The handling of _size by setting it to null when intersections are found is a good practice, indicating that the size needs recalculating.

test/N3Store-test.js (5)

Line range hint 10-14: Test block for Store export is well-implemented.

The tests correctly validate that Store is a function and behaves as a constructor.

---

Line range hint 16-45: Test block for an empty Store is comprehensive.

The tests effectively validate the behavior of an empty Store, ensuring it correctly reports size and handles operations like removing and importing quads.

---

Line range hint 47-112: Test block for Store operations is thorough and well-implemented.

The tests cover a wide range of operations, including every, some, and methods for adding and removing quads, ensuring that these operations behave as expected.

---

Line range hint 114-214: Test block for Store with initialized elements is robust and covers critical functionality.

The tests thoroughly check the behavior of a Store with initialized elements, focusing on adding and removing triples and correctly updating the store's size and contents.

---

Line range hint 2160-2180: Test block for concurrent read/write scenarios is well-crafted.

The tests effectively ensure that the Store maintains consistency and behaves as expected under concurrent read/write scenarios, which is crucial for data integrity.

[github-actions]

🎉 This PR is included in version 1.21.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀