-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react-remove-scroll in reach/dialog to v2.5.5 #950
Comments
In addition, is it possible to add the property Let me know, thank you. |
I'd like to make this request as well. There's a bug in the current version of react-remove-scroll where the scrollbar width is added twice when the scrollbar is no longer displayed (such as when a Dialog is open). |
Again, this problem is only present when removeScrollBar={true}. For those who don't mind leaving the scrollBar (only visually, scrolling is still locked), it would be nice to add the property to @reach/dialog! |
🐛 Bug report
This isn't directly related to reach-ui, rather a dependency of it.
Current Behavior
There are various bug fixed in the latest release of react-remove-scroll. Namely allowing range inputs to be used inside a dialog (link). At the moment, we have to
dangerouslyBypassScrollLock
and install the latest version of react-remove-scroll to benefit from the latest bug fixes.Expected behavior
Reach dialog to use the latest version of react-remove-scroll which contains various bug fixes.
Your environment
The text was updated successfully, but these errors were encountered: