Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 added component folder selection to generators #76

Merged
merged 4 commits into from
Nov 3, 2020
Merged

chore: 🔧 added component folder selection to generators #76

merged 4 commits into from
Nov 3, 2020

Conversation

adelin-b
Copy link
Contributor

@adelin-b adelin-b commented Oct 9, 2020

This MR add folder selection for the component generator so we can create components also in containers/components folders
plopgen

@coveralls
Copy link

coveralls commented Oct 9, 2020

Pull Request Test Coverage Report for Build 301127955

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.673%

Totals Coverage Status
Change from base Build 270590616: 0.0%
Covered Lines: 245
Relevant Lines: 245

💛 - Coveralls

@Can-Sahin
Copy link
Member

This is cool but tests are failing. You have to fix bit of things. I can take a look afterwards

https://github.com/react-boilerplate/react-boilerplate-cra-template/runs/1233538912?check_suite_focus=true

@Can-Sahin
Copy link
Member

I ll try this before the next release. Sorry for the delay. I moved to another country and pretty busy :)

@Can-Sahin Can-Sahin changed the title chore(internals): 🔧 choose the wanted component folder while generating chore: 🔧 added component folder selection to generators Nov 3, 2020
@Can-Sahin Can-Sahin merged commit de8e6fd into react-boilerplate:dev Nov 3, 2020
@adelin-b
Copy link
Contributor Author

adelin-b commented Nov 3, 2020

Oh wait I forgot about this pr, I ended up changing a few things that were not complete yet for my own usage, I will do an update this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants