Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧Fix typo in README #9

Merged
merged 2 commits into from
May 4, 2020
Merged

chore: 🔧Fix typo in README #9

merged 2 commits into from
May 4, 2020

Conversation

kyh
Copy link
Contributor

@kyh kyh commented Apr 30, 2020

React Boilerplate CRA Template

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@Can-Sahin Can-Sahin self-requested a review April 30, 2020 20:05
@Can-Sahin Can-Sahin closed this May 1, 2020
@Can-Sahin Can-Sahin reopened this May 4, 2020
@Can-Sahin Can-Sahin changed the title Fix typo in README chore: 🔧Fix typo in README May 4, 2020
@Can-Sahin
Copy link
Member

Sorry for this. This is the first forked PR and I was setting up status checks and commitlints etc. So had to play around with it

@Can-Sahin Can-Sahin merged commit bbc519a into react-boilerplate:dev May 4, 2020
Can-Sahin pushed a commit that referenced this pull request May 4, 2020
Can-Sahin pushed a commit that referenced this pull request May 4, 2020
Can-Sahin pushed a commit that referenced this pull request May 5, 2020
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 95242109

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.344%

Totals Coverage Status
Change from base Build 95230640: 0.0%
Covered Lines: 242
Relevant Lines: 242

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 95237097

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 99.344%

Totals Coverage Status
Change from base Build 91344135: -0.3%
Covered Lines: 242
Relevant Lines: 242

💛 - Coveralls

Thinh922001 pushed a commit to Thinh922001/KLTN-HUIT-FE that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants