Add custom indoor picker level #2448
Merged
+290
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luciferes thank you ❤️ LGTM @alvelig 🐽 |
This was referenced Apr 15, 2019
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
Add custom indoor picker level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
PR #2189 , it has no return when Indoor Building is out of focus.
What issue is this PR fixing?
Added new events onIndoorBuildingFocused(also return empty array when building is out of focus), onIndoorLevelActivated.
Added command setIndoorActiveLevelIndex
Added new example for Indoor Map.
How did you test this PR?
All new features are for Google Map.
Tested on Android emulator (Nexus 5), iOS Simulator (iPhone X), real Android device (HTC U11), real iOS device (iPhone 6S) by running example.