Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should stopPropagation when pressing esc #588

Merged
merged 2 commits into from
Jan 19, 2021
Merged

fix: should stopPropagation when pressing esc #588

merged 2 commits into from
Jan 19, 2021

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jan 18, 2021

fix ant-design/ant-design#28815

当下拉列表打开时,退出键应该停止冒泡。

@vercel
Copy link

vercel bot commented Jan 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/2odzp5gzz
✅ Preview: https://select-git-fix-28815.react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #588 (c0aca65) into master (ea9e62d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          20       20           
  Lines         965      967    +2     
  Branches      321      311   -10     
=======================================
+ Hits          958      960    +2     
  Misses          6        6           
  Partials        1        1           
Impacted Files Coverage Δ
src/OptionList.tsx 99.19% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9e62d...c0aca65. Read the comment docs.

src/OptionList.tsx Outdated Show resolved Hide resolved
@kerm1it kerm1it requested a review from zombieJ January 18, 2021 11:29
@zombieJ
Copy link
Member

zombieJ commented Jan 19, 2021

+ rc-select@12.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing dropdowns with ESC cancels Modal
3 participants