-
Notifications
You must be signed in to change notification settings - Fork 178
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useMergedState.ts #264
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
triggerChange
function, why not ignoresetInnerValue
whenvalue
present, i.e. controlled mode. I supposeinnerValue
does not take any effect in controlled mode though.In addition, it should be nice to add some logic detecting the switch controlled and uncontrolled mode, throw an error/warning as native react dose facebook/react#5821.
Not sure if I am missing some points though, if the above idea make any sense. I am glad to implement the code
The text was updated successfully, but these errors were encountered: