Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarChart with time xScale fails #29

Open
Guibod opened this issue Mar 16, 2016 · 3 comments
Open

BarChart with time xScale fails #29

Guibod opened this issue Mar 16, 2016 · 3 comments

Comments

@Guibod
Copy link

Guibod commented Mar 16, 2016

Bar relies on Xscale.bandwidth() that is not available in a Time scale.

@chilijung
Copy link
Contributor

Hi, @Guibod, why are you using time scale while you are using Bar chart? I'm suppose that passing an ordinal scale in Xscale.

see example here:

https://github.com/react-d3/react-d3-shape/blob/master/example/src/bar.jsx#L26

@Guibod
Copy link
Author

Guibod commented Mar 21, 2016

From my beginner point of view it sounded pretty smart to use a Time scale in an histogram, yet it was stupid in the logic universe.
Programmatically speaking it is still a possibility, you may need to assert scale type in the API since some unaware people (like myself) don't understand what they are doing sometimes. :)

@chilijung
Copy link
Contributor

Yeah, your right! Actually I've been really busy these days and there are many documents that haven't arrange yet. I'll do it when I have time. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants