Improve perf

react-dnd · Mar 26, 2015 · c41ba87 · c41ba87
1 parent d2dbf37
commit c41ba87
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/examples/_sortable-simple/Container.js b/examples/_sortable-simple/Container.js
@@ -8,6 +8,9 @@ import { configureDragDropContext, HTML5Backend } from 'react-dnd';
 class Container extends Component {
  constructor(props) {
  super(props);
+
+ this.moveCard = this.moveCard.bind(this);
+
  this.state = {
  cards: [{
  id: 1,
@@ -62,7 +65,7 @@ class Container extends Component {
  <Card key={card.id}
  id={card.id}
  text={card.text}
- moveCard={(id, afterId) => this.moveCard(id, afterId)} />
+ moveCard={this.moveCard} />
  );
  })}
  </div>

diff --git a/modules/configureDragDrop.js b/modules/configureDragDrop.js
@@ -10,6 +10,11 @@ const HANDLE_SEPARATOR = '🍣';
 
 export default function configureDragDrop(InnerComponent, { getHandlers, getProps, managerName = 'dragDropManager' }) {
  class DragDropContainer extends Component {
+ shouldComponentUpdate(nextProps, nextState) {
+ return !shallowEqual(nextProps, this.props) ||
+ !shallowEqual(nextState, this.state);
+ }
+
  constructor(props, context) {
  super(props);
 
@@ -31,6 +36,10 @@ export default function configureDragDrop(InnerComponent, { getHandlers, getProp
  }
 
  componentWillReceiveProps(nextProps) {
+ if (shallowEqual(nextProps, this.props)) {
+ return;
+ }
+
  const monitor = this.manager.getMonitor();
 
  monitor.removeChangeListener(this.handleChange);