Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case where coords are null in beginDrag #1082

Merged

Conversation

mattkrick
Copy link
Contributor

@mattkrick mattkrick commented Jun 15, 2018

This is a proposed solution to fix #986

Once I get word that this will be merged, I'll

  • write tests
  • clean up BEGIN_DRAG by removing stuff pertaining to coords
  • make INIT_COORDS more dry

until then i'm just sharing this with the community in case they need a way to work around #986

Copy link
Member

@darthtrevino darthtrevino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach looks reasonable, go ahead and proceed with the tests and updates you had in mind.

packages/dnd-core/src/actions/dragDrop.ts Outdated Show resolved Hide resolved
@darthtrevino darthtrevino merged commit 84db06e into react-dnd:master Nov 7, 2018
darthtrevino pushed a commit that referenced this pull request Feb 3, 2022
* fix case where coords are null in beginDrag

* chore: run prettier or input files

* fix: remove some "as any" casting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monitor.getClientOffset() return null in beginDrag
2 participants