Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve circular dependencies in react-dnd #2491

Merged
merged 1 commit into from
May 26, 2020
Merged

Conversation

darthtrevino
Copy link
Member

Fixes #2441

@darthtrevino darthtrevino changed the title Resolve circular dependencies is react-dnd Resolve circular dependencies in react-dnd May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #2491 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2491   +/-   ##
=======================================
  Coverage   52.33%   52.33%           
=======================================
  Files          87       87           
  Lines        2543     2543           
  Branches      492      492           
=======================================
  Hits         1331     1331           
  Misses       1212     1212           
Impacted Files Coverage Δ
...ckages/core/react-dnd/src/decorators/DragLayer.tsx 30.98% <100.00%> (ø)
.../core/react-dnd/src/decorators/decorateHandler.tsx 40.00% <100.00%> (ø)

@darthtrevino darthtrevino merged commit 52eaace into master May 26, 2020
@darthtrevino darthtrevino deleted the fix/circular_deps branch May 26, 2020 02:35
@wincent
Copy link

wincent commented May 26, 2020

Thanks @darthtrevino!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependencies in react-dnd limit usage possibilities
2 participants