Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend #2848 #2859

Merged
merged 7 commits into from
Nov 13, 2020
Merged

Extend #2848 #2859

merged 7 commits into from
Nov 13, 2020

Conversation

darthtrevino
Copy link
Member

@darthtrevino darthtrevino commented Nov 13, 2020

Updates #2848

  • Corrects the versioning strategy used.
  • Moves the document argument into the context object

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #2859 (275c429) into main (c94105d) will increase coverage by 0.01%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2859      +/-   ##
==========================================
+ Coverage   52.47%   52.49%   +0.01%     
==========================================
  Files          87       87              
  Lines        2544     2545       +1     
  Branches      472      473       +1     
==========================================
+ Hits         1335     1336       +1     
  Misses       1209     1209              
Impacted Files Coverage Δ
packages/backend-touch/src/OptionsReader.ts 48.14% <0.00%> (-3.86%) ⬇️
packages/backend-touch/src/TouchBackendImpl.ts 17.49% <0.00%> (+0.26%) ⬆️
packages/backend-touch/src/interfaces.ts 100.00% <ø> (ø)
packages/backend-html5/src/OptionsReader.ts 56.25% <20.00%> (-5.29%) ⬇️

@darthtrevino darthtrevino merged commit 2755dc9 into main Nov 13, 2020
@darthtrevino darthtrevino deleted the task/mod_pr branch November 13, 2020 17:23
darthtrevino added a commit that referenced this pull request Feb 3, 2022
* Allow client application to provide an ownerDocument that events can be attached to instead of defaulting to the root document.

* Prefer owner document over window document.

* Adds ability to specify a custom document for events to be attached to in touch backend.

* Patch release strategy.

* chore: cut semver document

* feat: add document to html5 and touch backend contexts

* chore: use minor version

Co-authored-by: james <jscampbell.05@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants