Skip to content

react-draggable dependency #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
antonsapyanov opened this issue Apr 20, 2018 · 1 comment
Closed
1 of 3 tasks

react-draggable dependency #88

antonsapyanov opened this issue Apr 20, 2018 · 1 comment

Comments

@antonsapyanov
Copy link

antonsapyanov commented Apr 20, 2018

  • Bug
  • Feature Request
  • Question

Problem Report

The issue has appeared after I migrated the project to the latest React version (16.3.2). I'm using react-grid-layout which has react-resizable as a dependency. react-resizable itself has react-draggable as a dependency of version ^2.2.6 || ^3.0.3. When I make a production build, react-resizable uses react-draggable@2.2.6 which uses (I'm not sure why, because it's not set as a direct dependency) react-dom@15.x. The project starts crashing with findDOMNode was called on an unmounted component. all the time when DraggableCore's componentWillUnmount hook is called. We use yarn in the project.

System Info

Node Version: 8.11.1
Browser: Chrome 65
OS: macOS 10.12.6

Possible solution

I'm not 100% sure, but can we set react-draggable dependency to "react-draggable": " ^3.0.3" only?

@antonsapyanov
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant