fix(ios): Merging empty object should not override current value #1064
+57
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Feb 20, 2024
|
Both platform passing
|
krizzu
commented
Feb 20, 2024
packages/default-storage/example/ios/AsyncStorageExample/AsyncStorageDevSupport.m
Outdated
Show resolved
Hide resolved
|
@tido64 thanks for the review! |
|
🎉 This PR is included in version 1.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 6, 2024
This was referenced Sep 8, 2024
This was referenced Sep 10, 2024
This was referenced Sep 11, 2024
This was referenced Sep 14, 2024
This was referenced Sep 17, 2024
This was referenced Sep 18, 2024
This was referenced Sep 20, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Passing an empty object to
multiMergeavoided looping over keys to compare/merge. If the provided object is empty now, simply use the original object instead.Closes #1046