fix: check directory before call delete on iOS #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Feb 21, 2024
| @@ -869,8 +869,14 @@ - (BOOL)_passthroughDelegate | |||
|
|
|||
| [_manifest removeAllObjects]; | |||
| [RCTGetCache() removeAllObjects]; | |||
| NSDictionary *error = RCTDeleteStorageDirectory(); | |||
There was a problem hiding this comment.
I think it would be simpler if we check whether error.code == NSFileNoSuchFileError in RCTDeleteStorageDirectory() and ignore it.
There was a problem hiding this comment.
yeah, it works and is also more clean, thanks for that.
I'm kinda new on Objective-C, I only return nil to ignore, if it was better to return another thing I could change again.
tido64
approved these changes
Feb 22, 2024
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
|
🎉 This PR is included in version 1.22.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 6, 2024
This was referenced Sep 8, 2024
This was referenced Sep 10, 2024
This was referenced Sep 11, 2024
This was referenced Sep 14, 2024
This was referenced Sep 17, 2024
This was referenced Sep 18, 2024
This was referenced Sep 20, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before executing the
clearmethod on iOS, check if the directory exists usingRCTGetStorageDirectoryto avoid throwing an error.Fixes #1020
Test Plan
To test this change I created an app from scratch and call
await AsyncStorage.clear().The component code is available on gist
before:
before.mp4
after:
after.mp4