-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): bridgeless mode broken on react-native 0.74 #1068
Merged
tido64
merged 1 commit into
react-native-async-storage:main
from
Kudo:@kudo/fix-rn074-bridgeless
Feb 28, 2024
Merged
fix(android): bridgeless mode broken on react-native 0.74 #1068
tido64
merged 1 commit into
react-native-async-storage:main
from
Kudo:@kudo/fix-rn074-bridgeless
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Kudo ❤️
🎉 This PR is included in version 1.22.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @Kudo 🙏 |
thank you folks for merging and releasing the fix quickly. |
This was referenced Sep 6, 2024
This was referenced Sep 8, 2024
This was referenced Sep 10, 2024
This was referenced Sep 11, 2024
This was referenced Sep 14, 2024
This was referenced Sep 17, 2024
This was referenced Sep 18, 2024
This was referenced Sep 20, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to fix the
[@RNC/AsyncStorage]: NativeModule: AsyncStorage is null
error when running on react-native@0.74.0-rc.1. The regression was coming from facebook/react-native#41412 and facebook/react-native#43213 has more discussion. This PR follows the create-react-native-library template to rely on BuildConfigTest Plan