Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): bridgeless mode broken on react-native 0.74 #1068

Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Feb 28, 2024

Summary

This PR tries to fix the [@RNC/AsyncStorage]: NativeModule: AsyncStorage is null error when running on react-native@0.74.0-rc.1. The regression was coming from facebook/react-native#41412 and facebook/react-native#43213 has more discussion. This PR follows the create-react-native-library template to rely on BuildConfig

Test Plan

$ npx @react-native-community/cli@latest init RN074 --version next
$ cd RN074
$ yarn add @react-native-async-storage/async-storage
# edit App.tsx for using async-storage
$ cd android
$ ./gradlew -PnewArchEnabled=true :app:installDebug
$ ./gradlew -PnewArchEnabled=true -PAsyncStorage_useNextStorage=true :app:installDebug

Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kudo ❤️

@tido64 tido64 merged commit 253126d into react-native-async-storage:main Feb 28, 2024
10 checks passed
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.22.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu
Copy link
Member

krizzu commented Feb 28, 2024

Thanks @Kudo 🙏

@Kudo Kudo deleted the @kudo/fix-rn074-bridgeless branch February 28, 2024 12:32
@Kudo
Copy link
Contributor Author

Kudo commented Feb 28, 2024

thank you folks for merging and releasing the fix quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants