Skip to content

Why 6mb dataset size for android? #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nthalk opened this issue Apr 17, 2019 · 2 comments
Closed

Why 6mb dataset size for android? #83

Nthalk opened this issue Apr 17, 2019 · 2 comments
Labels
platform: Android This is Android specific question General question about usage

Comments

@Nthalk
Copy link

Nthalk commented Apr 17, 2019

I want to know why we carry forward a non-configurable, arbitrary value (6mb) for the maximum database size for Android, while leaving IOS unlimited.

Especially when I'll just get around this with JSON stringify and react-native-sqlite-storage.

https://github.com/react-native-community/react-native-async-storage/blob/c57cbeb25034c4291cc148084ad3933266daf641/android/src/main/java/com/reactnativecommunity/asyncstorage/ReactDatabaseSupplier.java#L46

@tido64 tido64 added platform: Android This is Android specific question General question about usage labels Apr 17, 2019
@krizzu
Copy link
Member

krizzu commented Apr 18, 2019

Hey @Nthalk,

We did not change the initial limit, because of a note left from original creators. I'm not quite sure if it's still relevant or not, but I think we could let this value be set from user (for example, a new limit passed as argument to AsyncStorage package in MainApplication.

FYI, here are limits of SQLite DB.

thanks.

@tido64
Copy link
Member

tido64 commented May 10, 2019

I'm closing this issue since we've just merged a change to make this limit configurable. Please try it out and let us know how you go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This is Android specific question General question about usage
Projects
None yet
Development

No branches or pull requests

3 participants