Skip to content

Incorrect podspec's git tag #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thorny-thorny opened this issue May 1, 2019 · 2 comments · Fixed by #93
Closed

Incorrect podspec's git tag #92

thorny-thorny opened this issue May 1, 2019 · 2 comments · Fixed by #93
Labels
bug Something isn't working platform: iOS This is iOS specific

Comments

@thorny-thorny
Copy link
Contributor

Current behavior

pod install causes an error (at least when installing AsyncStorage manually): Could not find remote branch 1.2.1 to clone.

Expected behavior

No error occurs.

Repro steps

  1. Create new empty RN project with iOS project based on Cocoapods
  2. Add "@react-native-community/async-storage": "^1.2.1" to package.json dependencies
  3. npm install
  4. Add pod 'react-native-async-storage', :podspec => '../node_modules/@react-native-community/async-storage' to Podfile
  5. pod install

Environment

  • Async Storage version: 1.2.1
  • React-Native version: 0.59.1
  • Platform tested: iOS (the issue is not applicable to Android)
  • Logs/Error that are relevant:
[!] Error installing react-native-async-storage
[!] /usr/bin/git clone https://github.com/react-native-community/react-native-async-storage.git /var/folders/... --template= --single-branch --depth 1 --branch 1.2.1

Cloning into '/var/folders/...'...
warning: Could not find remote branch 1.2.1 to clone.
@tido64 tido64 added bug Something isn't working platform: iOS This is iOS specific PR ready 💯 labels May 1, 2019
@krizzu krizzu closed this as completed in #93 May 1, 2019
@krizzu
Copy link
Member

krizzu commented May 1, 2019

@happy-thorny Thanks a lot for raising that! Your PR with fix is merged. Should be out soon.

thanks.

@krizzu
Copy link
Member

krizzu commented May 1, 2019

🎉 This issue has been resolved in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the Released label May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform: iOS This is iOS specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants