feat(windows): accessibilityLabel support (#805)

* added accessibilityLabel support for windows * reverted unwanted changes * resolve linting error * fixing linting
react-native-datetimepicker · Sep 18, 2023 · 0228eca · 0228eca
1 parent 4770080
commit 0228eca
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 0 deletions.
diff --git a/src/datetimepicker.windows.js b/src/datetimepicker.windows.js
@@ -39,6 +39,7 @@ export default function RNDateTimePickerQWE(
   sharedPropsValidation({value: props?.value});
 
   const localProps = {
+    accessibilityLabel: props.accessibilityLabel,
     dayOfWeekFormat: props.dayOfWeekFormat,
     dateFormat: props.dateFormat,
     firstDayOfWeek: props.firstDayOfWeek,

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -211,6 +211,7 @@ export type WindowsNativeProps = Readonly<
       timeZoneOffsetInSeconds?: number;
       is24Hour?: boolean;
       minuteInterval?: number;
+      accessibilityLabel?: string;
     }
 >;
 

diff --git a/src/types.js b/src/types.js
@@ -254,4 +254,5 @@ export type WindowsNativeProps = $ReadOnly<{|
   timeZoneOffsetInSeconds?: number,
   is24Hour?: boolean,
   minuteInterval?: number,
+  accessibilityLabel?: string,
 |}>;
diff --git a/windows/DateTimePickerWindows/DateTimePickerView.cpp b/windows/DateTimePickerWindows/DateTimePickerView.cpp
@@ -110,6 +110,11 @@ namespace winrt::DateTimePicker::implementation {
                     m_timeZoneOffsetInSeconds = propertyValue.AsInt64();
                 }
             }
+            else if (propertyName == "accessibilityLabel") {
+                if (!propertyValue.IsNull()) {
+                    this->Name(to_hstring(propertyValue.AsString()));
+                }
+            }
         }
 
         if (updateMaxDate) {

diff --git a/windows/DateTimePickerWindows/DateTimePickerViewManager.cpp b/windows/DateTimePickerWindows/DateTimePickerViewManager.cpp
@@ -39,6 +39,7 @@ namespace winrt::DateTimePicker::implementation {
     IMapView<hstring, ViewManagerPropertyType> DateTimePickerViewManager::NativeProps() noexcept {
         auto nativeProps = winrt::single_threaded_map<hstring, ViewManagerPropertyType>();
 
+        nativeProps.Insert(L"accessibilityLabel", ViewManagerPropertyType::String);
         nativeProps.Insert(L"dayOfWeekFormat", ViewManagerPropertyType::String);
         nativeProps.Insert(L"dateFormat", ViewManagerPropertyType::String);
         nativeProps.Insert(L"firstDayOfWeek", ViewManagerPropertyType::Number);