Fix accessing UIViewManager configs #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XeroX
reviewed
Jun 7, 2019
src/js/LottieView.js
Outdated
| @@ -120,7 +120,7 @@ class LottieView extends React.Component { | |||
| android: () => | |||
| UIManager.dispatchViewManagerCommand( | |||
| handle, | |||
| UIManager.LottieAnimationView.Commands[name], | |||
| UIManager.getViewManagerConfig('LottieAnimationView').Commands[name], | |||
There was a problem hiding this comment.
Would this break support of RN < 0.58 since getViewManagerConfig doesn't exist in older versions or am I missing something?
There was a problem hiding this comment.
@andrewtremblay can you create a fix for this and ping me once it's ready?
There was a problem hiding this comment.
@emilioicai: Just pushed a commit that should address the backwards compatibility issues.
Thanks everyone for your patience!
|
Thank you for your hard work addressing these config fixes. How soon can we expect a merge? |
emilioicai
approved these changes
Jul 3, 2019
emilioicai
approved these changes
Jul 3, 2019
|
thanks @andrewtremblay ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR should remove the warning regarding UIViewManager accessing LottieAnimationView directly.
See the source comments for more information:
https://github.com/facebook/react-native/blob/fc94ade11c09bc5ed027f7ebd58341d851d4c3fb/Libraries/ReactNative/UIManagerProperties.js#L15
Closes #437
Test Plan
Compatibility
Checklist
CHANGELOG.md