Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Looking for new maintainers #3000

Closed
sibelius opened this issue Oct 14, 2020 · 40 comments
Closed

Looking for new maintainers #3000

sibelius opened this issue Oct 14, 2020 · 40 comments
Labels
stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@sibelius
Copy link
Collaborator

I'm stepping down from maintaining react-native-camera

Please comment if you wanna maintain this package

Another direction would be deprecated this package (#2942) and focus on expo-camera instead

@sibelius sibelius pinned this issue Oct 14, 2020
@fabOnReact
Copy link
Contributor

This weekend I will give a look at the issue. Thanks

@doranteseduardo
Copy link
Contributor

Considering that a lot of people and projects use this library, I'm sure this project must be kept alive.
I'll talk with my team, I'm sure we can maintain it.

@MateusAndrade
Copy link
Collaborator

I can help with that, but it would be amazing having someone focused on this project.

@mateosilguero
Copy link

Could i help ?

@msriaz
Copy link

msriaz commented Oct 18, 2020

I would love to help in maintaining this package.

@diegotsi
Copy link
Collaborator

Hi @sibelius! I can help!

@np6176a
Copy link
Collaborator

np6176a commented Oct 29, 2020

Me too!! @sibelius I would love to help maintain this project.

@sibelius
Copy link
Collaborator Author

to start review and answer or close issues and pull requests

merge pull requests that make sense after testing in android and ios device

@Yandamuri
Copy link

We are starting new project and thinking to use this package. Can we go ahead with this package or is it going to be stopped in the future?

@renatobenks
Copy link
Collaborator

renatobenks commented Nov 19, 2020

@Yandamuri you can go ahead! it will just be stopped for a while, until be completely re-designed, in order to improve it

@Yandamuri
Copy link

@renatobenks that's great to hear. Thanks a lot.

@mattonit
Copy link
Collaborator

mattonit commented Dec 5, 2020

I hope it's not too late :) If you're still looking for maintainers, I'd be happy to help with keeping this repo alive

@russelRajitha
Copy link
Collaborator

I am using this app for lot of my projects. i'am really happy to be a contributor with this module and i see some issues like crashing android app are still open.

@walesl04
Copy link
Collaborator

I hope it's not too late, i wish i could help.

@mattonit
Copy link
Collaborator

@sibelius you've added a lot of new maintainers - can we close this issue or you are going to extend this group?

@MarcoScabbiolo
Copy link
Collaborator

Hey @sibelius i'd be glad to help!

@bkvirendra
Copy link
Collaborator

@sibelius, we have been using this package for a while now and would be more than happy to assist with further development.

@MarcoScabbiolo
Copy link
Collaborator

Thanks to everyone ❤️
All hands on deck for the next version!!! #3100

@geonsangyoo
Copy link

geonsangyoo commented Feb 9, 2021

@MarcoScabbiolo @sibelius

Hi, This is Geonsang.
I always appreciate your team for making us to be able to use react-native-camera library. 😄

Hopefully it is not too late, Is there a seat available as a maintainer?
I would like to onboard on your project and contribute to it more as much as I can, which would be my honor! ^^

Thank you 👍

@theasc
Copy link
Contributor

theasc commented Feb 11, 2021

I would also like to help :)

@ZacharyLangley
Copy link

The company I work for uses this package and I would like to be added as a maintainer.

@MarcoScabbiolo
Copy link
Collaborator

To anyone looking to contribute, please do so, permissions will be granted as they are needed, nothin prevents you from answering issues, and creating PRs.

@fabOnReact
Copy link
Contributor

fabOnReact commented Mar 31, 2021

can we have stalebot removed? The repo has only 77 open issues so it is hard finding an issue to solve if you want to contribute

@mayank-budhiraja
Copy link

I am happy to contribute to the project.

@0100010089
Copy link

I hope it's not too late!
Can I help?

@stale
Copy link

stale bot commented Jul 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and i will leave this open.

@stale stale bot added the stale There has been a lack of activity on this issue and it may be closed soon. label Jul 19, 2021
@MateusAndrade MateusAndrade removed the stale There has been a lack of activity on this issue and it may be closed soon. label Jul 21, 2021
@ShakeelAhmad-dev
Copy link

it's really good package ...
I want to contribute ...

@pke
Copy link

pke commented Sep 27, 2021

I would be able to help maintain this repo. At least merge fully tested PRs once in a while.
Also would bring in support for volume buttons as per #764 using non-obstrusive feature detection code (when the react native button bundle is available)

@pke
Copy link

pke commented Oct 4, 2021

To anyone looking to contribute, please do so, permissions will be granted as they are needed, nothin prevents you from answering issues, and creating PRs.

@MarcoScabbiolo well PRs are piling up already. What prevents them from being merged? Without a clear direction it does not seem to make much sense to work on PRs if they get stale here.

For instance the lib still uses outdated ref handling. This could probably patched easily. I am working on it to patch it locally, since the current implementation does not allow the RNCamer to be mocked properly. But why maintain a PR alongside my branch when its never merged into main here?

@MarcoScabbiolo
Copy link
Collaborator

@pke Sorry if any other issues or discussions are misleading, I've already expressed my mind about this repo and stopped working on the v4 version. My recommendation for you and anyone else is to migrate to react-native-vision-camera. There is also a discussion about making it the official successor of react-native-camera. If it was only up to me, I would officialy deprecate react-native-camera and encourage users to move to react-native-vision-camera but I'm not the only one calling the shots here and honestly I've been out of RN in general for while now.

@pke
Copy link

pke commented Oct 4, 2021

@MarcoScabbiolo oh very cool! I was not aware of the vision camera. And it works in Android too it seems. I like the frame snippets to integrate with frame analysing tooling.
I'll give it a try, thanks!

@stale
Copy link

stale bot commented Dec 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and i will leave this open.

@stale stale bot added the stale There has been a lack of activity on this issue and it may be closed soon. label Dec 3, 2021
@stale
Copy link

stale bot commented Dec 10, 2021

Closing this issue after a prolonged period of inactivity. Fell free to reopen this issue, if this still affecting you.

@stale stale bot closed this as completed Dec 10, 2021
@kidculli
Copy link

kidculli commented Jan 7, 2022

I have tried using react-native-vision-camera however it is definitely not fit for production use. I encountered bugs that would cause my application to crash. react-native-camera is much more stable. We should at the very least revert the readme back instead of pushing people to use react-native-vision-camera.

Also we should advertise additional options

@ahron1
Copy link

ahron1 commented Jan 9, 2022

It seems there are many volunteers to maintain this. So why is it deprecated? A lot of people are already using this in prod. Why make them migrate if there's no shortage of maintainers?

@MarcoScabbiolo
Copy link
Collaborator

There is shortage of maintainability, not maintainers. It is deprecated because for several reasons the base code is unsustainable, specially in Android. The end-game of restructuring, refactoring and taking the project to a sustainable status is the same end-game react-native-vision-camera is aiming for, and is well on track to reach and way ahead of react-native-camera-v4 partly because it doesn't have to deal with the multiple backwards compatibility issues and braking changes that arise when attempting to refactor from the react-native-camera code, and mainly because it is under very active development.

This is why this has been deprecated and why react-native-vision-camera has been pointed out as the most viable successor. It doesn't mean it's the only option, there are others but their foundations are different. React-native-camera-kit is targeted to a specific use case (Tesla's) and expo's is well... Expo, not RN. What react-native-camera was to me and probably many of you too, is the general-purpose RN library to integrate with the native camera/s. And as I've said many times before, Expo native modules should expand RN ones adding their own Expo stuff, because Expo is built on top of RN, so Expo modules should be built on top of RN ones. It is a waste of resources to have a dedicated from-scratch camera module only for expo, when all of those resources could be dedicated to create a RN module compatible with Expo.

The deprecation notice really means: Keep using react-native-camera if you want, but all the people that have been working on it have agreed that the project is unsustainable and should be replaced. And we luckily have a successor to put our efforts into, to make it the next react-native-camera we can all use for many purposes and collaborate on.

And don't forget this is a community driven project, if you wan't to keep using react-native-camera and contribute on it you can resume the react-native-camera-v4 project or you can fork react-native-camera and create another potential module to use.

@Mattimus333
Copy link

Mattimus333 commented Feb 22, 2022

I have tried using react-native-vision-camera however it is definitely not fit for production use. I encountered bugs that would cause my application to crash. react-native-camera is much more stable. We should at the very least revert the readme back instead of pushing people to use react-native-vision-camera.

Also we should advertise additional options

Thank you for this. React-native-vision-camera doesn't even npm install properly. The "example" is straight up unusable it's so buggy. Can't believe that's what this repo is suggesting people switch over to. react-native-camera-kit looks pretty good.

jonthysell added a commit to jonthysell/react-native-windows-samples that referenced this issue Mar 11, 2022
We have limited resources to maintain samples in this repo. Due to the deprecation of react-native-camera, I'm moving the CameraDemo sample to the samples-old folder.

See react-native-camera/react-native-camera#3000
jonthysell added a commit to microsoft/react-native-windows-samples that referenced this issue Mar 11, 2022
We have limited resources to maintain samples in this repo. Due to the deprecation of react-native-camera, I'm moving the CameraDemo sample to the samples-old folder.

See react-native-camera/react-native-camera#3000
@nes123
Copy link

nes123 commented Aug 20, 2022

I have tried using react-native-vision-camera however it is definitely not fit for production use. I encountered bugs that would cause my application to crash. react-native-camera is much more stable. We should at the very least revert the readme back instead of pushing people to use react-native-vision-camera.
Also we should advertise additional options

Thank you for this. React-native-vision-camera doesn't even npm install properly. The "example" is straight up unusable it's so buggy. Can't believe that's what this repo is suggesting people switch over to. react-native-camera-kit looks pretty good.

React-native-camera-kit seems weak for the android use case. Any thoughts on that?

@mat2718
Copy link
Collaborator

mat2718 commented Sep 26, 2022

@sibelius i know that this library was discontinued. is there anyway i could become a maintainer for this library?

@ahron1
Copy link

ahron1 commented Sep 28, 2022

@sibelius i know that this library was discontinued. is there anyway i could become a maintainer for this library?

#3000 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests