Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Maps TMS URL tile support #2732

Merged
merged 4 commits into from
Mar 13, 2019
Merged

Google Maps TMS URL tile support #2732

merged 4 commits into from
Mar 13, 2019

Conversation

arosendorff
Copy link
Contributor

Does any other open PR do the same thing?

#2118
This PR has merge conflicts and has appeared to have stalled.

What issue is this PR fixing?

None

How did you test this PR?

  1. Set up a simple tile server serving two different tiles, one with the normal XYZ coordinate, and another with the inverted Y value.
  2. Implement with and then without flipY to ensure that the correct tile is displayed, and both in the same place.

This has been tested on iOS simulator, and Android and iOS devices.

@arosendorff
Copy link
Contributor Author

Hi there, for our app we forked react-native-maps to allow use to display TMS tiles (origin coordinate is at the bottom right instead of the top left) using the Google Maps component and thought it might be useful to merge into the base repo!

@rborn
Copy link
Collaborator

rborn commented Mar 12, 2019

LGTM @alvelig @christopherdro 🐽

@christopherdro
Copy link
Collaborator

@arosendorff Thank you for this. Any chance you add the recommendation from the other PR to add support for iOS as well? self.tileOverlay.geometryFlipped = YES

@arosendorff
Copy link
Contributor Author

@christopherdro Yeah I can add that quickly!

@arosendorff
Copy link
Contributor Author

@alvelig @christopherdro I have updated the PR to include the flip for Apple Maps. Let me know if it all looks good to you!

@sebqq
Copy link

sebqq commented Mar 13, 2019

hello @arosendorff I can see that your PR has really close to the issue that I'm trying to solve right now. Please, could you take a look at #2733 . Thank you so much!

@christopherdro christopherdro mentioned this pull request Mar 13, 2019
Closed
@christopherdro christopherdro merged commit 1340543 into react-native-maps:master Mar 13, 2019
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
@arosendorff @christopherdro
Google Maps TMS URL tile support (react-native-maps#2732)
69302ee 
* Implement ability to flip y coordinate for Google Map tiles.

* Update README to detail method of inverting tile y coordinates.

* Update MapUrlTile to include flipY prop.

* Implement using flipped y tiles on Apple Maps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherdro christopherdro christopherdro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arosendorff @rborn @christopherdro @sebqq