-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GeoJSON support by default #2959
Conversation
@christopherdro @alvelig any thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about GeometryCollection
type?
@nabati are we really need this |
Considering my notes on the |
Deleted uuid generation, used index instead. |
So, what about to merge? |
LGTM |
LGTM. Could we update the docs and add a basic version in the example app? |
@christopherdro Added geojson description to docs and examples |
@christopherdro @rborn @alvelig Guys, is there anything else I should do? |
@Peretz30 Could you address the lint errors show in travis? |
@christopherdro done |
@Peretz30 will you add bbox feature as it is a common thing on geojson too ? but i don't think your library handles it yet |
@GuillotJessica did you mean |
@Peretz30 i meant to display a map regarding the bbox received in a geojson not to get the bbox displayed |
@GuillotJessica I am sorry, but I don't understand what you want to do. Can you, please, provide more details about it? |
i mean if i provide a geojson with boundingBox, i would like the library mapBoundaries to be set accordingly |
@GuillotJessica How do you want to provide geojson with boundingBox? Can you, please, post your question with some code on StackOverflow |
* commit '3ae31e4a336102538ee422a0d4e71a2ea32647bb': (24 commits) [0.26.1] Release rn 0.60.5 support (react-native-maps#3020) "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103) [0.26.0] Release Add Heatmap back in (react-native-maps#3064) Fixes NPE while removing already removed marker. (react-native-maps#3032) Add flat property binding on Marker for iOS (react-native-maps#3051) Add heading to the onUserLocationChange listener (react-native-maps#3045) Add onDoublePress callback (react-native-maps#2937) Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935) updating pods for compile error (react-native-maps#3011) add overlay onPress event (react-native-maps#3007) Fix playServicesVersion name in installation docs (react-native-maps#3016) Update index.d.ts (react-native-maps#2887) Add @ReactModule annotation to help turbomodules processor (react-native-maps#3001) Google Maps - Heatmaps for Android and iOS (react-native-maps#2960) Added GeoJSON support by default (react-native-maps#2959) Update GoogleMaps pos to 3.2.0 (react-native-maps#2999) convert to new react native config format (RN 0.60 (react-native-maps#2975) fix select annotation when show/hide callout view (react-native-maps#2973) ... # Conflicts: # package.json
* Added GeoJSON component * deleted uuid generation, used index instead * Added geojson description to docs and examples * Added import to App.js in examples * fixed prettier syntax errors * fixed another prettier errors
Does any other open PR do the same thing?
No
What issue is this PR fixing?
None
How did you test this PR?
Tested on Android Real Device
I think that the less dependencies the better and GeoJSON support should be by default in this package.