0.60.6 Discussion

[kelset]

Conversation on this thread are limited to 0.60.5 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.60.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.60-stable branch yourself, in order to ensure that the process proceeds smoothly.

[kesha-antonov]

Good job guys

[Ilphrin]

Thank you all so much for your awesome work! =D Can't wait to have enough time to contribute myself fur future releases!
I don't see any commit that should be merged in a hurry for next minor release (even though I'd love to see the new jsc-android update and this ScrollView sticky header ;) ), but I'll stay tuned

[ImBeCiliC]

Hello this was also posted to 0.59.x and sadly didn't made it into the 0.59.10 release. Can the new Keyboard behaviour on Android come into the next 0.60.x release?
facebook/react-native@d88e470
It's from this old and long discussion facebook/react-native#14045
Thanks

[sunnylqm]

Please cherry pick facebook/react-native@76c50c1

[thymikee]

• Bump CLI to ^2.2.0 facebook/react-native@5b448ec
• Remove unnecessary flag when running JS server on Windows facebook/react-native@a162554

[sunnylqm]

@dulmandakh Do you mean this one? facebook/react-native@7254bab

[AndrewJack]

Can this iOS 13 fix get cherry picked?
facebook/react-native@46bdb41

Related issue: facebook/react-native#25181

[kelset]

quick update: I changed this conversation to about 0.60.3 aiming for 0.60.4 since Hermes was micdropped during ChainReact 😂

We'll likely do a new release soon-ish, as soon as this fix for the CLI is implemented so that we can cherry pick this facebook/react-native@7254bab

Also, because of Hermes landing in branch directly a few of the CI jobs we have set up in that branch are now failing, which lowers a bit my confidence on ensuring that the releases are as bug free as we can get them to be - so it's likely that patch releases will be small and limited while aiming for a quick rollout of 0.61 (more details about it will arrive in the next couple weeks, we are waiting for some things to land).

[fungilation]

To be clear of what you are saying. For CI fixes and larger changes in RN needed to accommodate Hermes, those are going to land in 0.61 instead? So it's reasonable that production apps should wait for 0.61 before using Hermes?

[kelset]

Oh no - sorry I meant that the Hermes commit broke some CI jobs that are set up in the 0.60 branch.

To clarify: you can use Hermes via 0.60.3 even in production (AFAIK - I haven't seen any major issues in the main repo), but simply since the CI is kinda broken in the 0.60-branch it means we have less ways to detect eventual issues that may be caused by some cherry picks.

But the CI on master branch is actually been improved a lot since 0.60-branch was cut, and it's green again from what I can see so 0.61-branch will have a more stable and reliable CI.

[janicduplessis]

facebook/react-native@88e18b6 to fix blob memory leak on Android. Might also need janicduplessis/react-native@6c2f4f5 (hermes has not landed on master so can't land this diff) which caused a crash for me when trying out hermes.

[kelset]

@janicduplessis I think that that diff will have to be done as PR against the 0.60-branch to see it happen in 0.60.x because Hermes was landed first in the branch so I don't think that the code will be precisely the same once it's on master (so yeah, I fear you may having to end up doing that PR twice 😓)

[mjmasn]

facebook/react-native@b432b8f please @kelset!

[matpaul]

svg animation with nativeDriver
facebook/react-native@bdc530b

[thymikee]

CLI bump: facebook/react-native@fafe5ee

[artdent]

facebook/react-native@6ef9106 would be a useful cherrypick - it fixes use_native_modules! in certain projects that use Cocoapods. It's a fix spun out of facebook/react-native#25349, which is a broader umbrella issue.

[mikehardy]

Indeed @owinter86 - all hail the mighty upgrade-helper - note that react-native follows no semver convention and breaking changes show up in patches. You can never safely upgrade without checking the diff from upgrade-helper (or rn-diff-purge and before that rn-diff, same team as upgrade-helper, the tool just keeps evolving and upgrade-helper is the current best). Luckily this one is easy

[kelset]

@sijad please read the explanation here.

---

react-native follows no semver convention and breaking changes show up in patches.

Yeah, as harsh as it may sound semver is not really followed - but we strive to, for patch (x.x.1) releases to not have changes, the fishhook one was a mistake, sorry 😓

---

@benevbright @HarshitMadhav please open an issue in the main repo for it.

---

General note: we will likely not do a next 0.60.x release because of what said previously about faulty CI. We are trying to get a first 61 RC up and running soon.

[sunnylqm]

@benevbright Seems a misunderstanding from the beginning. facebook/react-native#21801 (comment)

[grabbou]

Thanks @kelset for all the help! I had an accident that week and couldn't finish the release myself! Now, I am working on the 0.61 in a different thread.

[janicduplessis]

I finally managed to land the Android blob fix properly. Hopefully it can merge cleanly on 0.60, if not I guess we'll just have to wait for 0.61

facebook/react-native@9b2374b

[grabbou]

I am closing this issue as we are shipping 0.61.0 release right now. Please give it a try and comment on the appropriate issue thread if necessary.